build: use broader detection for 'help' #53045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
aduh95
approved these changes
May 23, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
jasnell
approved these changes
May 25, 2024
aduh95
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/53045 ✔ Done loading data for nodejs/node/pull/53045 ----------------------------------- PR info ------------------------------------ Title build: use broader detection for 'help' (#53045) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch RedYetiDev:patch-31 -> nodejs:main Labels windows, build, author ready, needs-ci Commits 2 - build: use broader detection for 'help' - Update vcbuild.bat Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/53045 Reviewed-By: Stefan Stojanovic Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53045 Reviewed-By: Stefan Stojanovic Reviewed-By: Antoine du Hamel Reviewed-By: James M Snell -------------------------------------------------------------------------------- ℹ This PR was created on Sat, 18 May 2024 13:13:35 GMT ✔ Approvals: 3 ✔ - Stefan Stojanovic (@StefanStojanovic): https://github.com/nodejs/node/pull/53045#pullrequestreview-2068005716 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/53045#pullrequestreview-2073211950 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/53045#pullrequestreview-2078304184 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-05-23T14:44:20Z: https://ci.nodejs.org/job/node-test-pull-request/59374/ - Querying data for job/node-test-pull-request/59374/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD e818eee5af..0d7b5a938c main -> origin/main ✔ origin/main is now up-to-date main is out of sync with origin/main. Mismatched commits: - 0d7b5a938c doc: move all TLS-PSK documentation to its section -------------------------------------------------------------------------------- HEAD is now at 0d7b5a938c doc: move all TLS-PSK documentation to its section ✔ Reset to origin/main - Downloading patch for 53045 From https://github.com/nodejs/node * branch refs/pull/53045/merge -> FETCH_HEAD ✔ Fetched commits as 0d7b5a938c80..b3c2d70d3fb8 -------------------------------------------------------------------------------- Auto-merging vcbuild.bat [main 295b9b7964] build: use broader detection for 'help' Author: Aviv Keller <[email protected]> Date: Sat May 18 09:13:15 2024 -0400 1 file changed, 3 insertions(+), 8 deletions(-) Auto-merging vcbuild.bat [main a5f8de17b9] Update vcbuild.bat Author: Aviv Keller <[email protected]> Date: Mon May 20 07:23:23 2024 -0400 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4)https://github.com/nodejs/node/actions/runs/9237455242 |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in d0a7272 |
targos
pushed a commit
that referenced
this pull request
Jun 1, 2024
PR-URL: #53045 Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
PR-URL: nodejs#53045 Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
PR-URL: nodejs#53045 Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53045 Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
PR-URL: #53045 Reviewed-By: Stefan Stojanovic <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the
vcbuild.batto use a broader way to detect help/?