-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Mention possibility of corepack enable npm
#53257
Conversation
| [pnpm][] | `pnpm`, `pnpx` | | ||
| [npm][]* | `npm`, `npx` | | ||
|
||
\* Not enabled by default. Use `corepack enable npm` to do so. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is only referring to NPM, couldn't it be referenced by name, and not a "*"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could do that if you want me to.
Wanted to raise attention that it is a special case as soon as you read the entry in the table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It’s your call, I’m not a CODEOWNER, so it’s up to you :-).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion but there is quite a lot of history here, the npm team does not support and discourages this (though they believe it's not their place to tell us).
cc @nodejs/package-maintenance
Due to the situation here I believe this change cannot land. See nodejs/corepack#418 for more details. |
Understood the situation is complicated. |
After reading https://www.totaltypescript.com/how-to-use-corepack, I realized that the Corepack docs page has some shortfalls:
corepack enable npm
) is never mentioned anywhere.With this PR, I believe to correct the docs according to the current implementation. If you anyways plan to change it, feel free to close.