Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

repl: handle object patterns without values #53331

Merged
merged 1 commit into from
Jun 7, 2024
Merged

repl: handle object patterns without values #53331

merged 1 commit into from
Jun 7, 2024

Conversation

lukehaas
Copy link
Contributor

@lukehaas lukehaas commented Jun 4, 2024

Fixes #53328

For the ObjectPattern of type RestElement the child node is in the argument property.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. repl Issues and PRs related to the REPL subsystem. labels Jun 4, 2024
@cola119
Copy link
Member

cola119 commented Jun 5, 2024

@lukehaas Can you please address the lint errors?

BridgeAR
BridgeAR approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thank you for the fix and congratulations to your first contribution!

@BridgeAR BridgeAR added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2024
@BridgeAR
Copy link
Member

BridgeAR commented Jun 5, 2024

Ideally, you could still force push with a commit message that adheres to our commit message standard. In this case e.g., repl: fix await object patterns without values

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59660/

@lukehaas
Copy link
Contributor Author

lukehaas commented Jun 5, 2024

@BridgeAR thanks. I've updated the commit message.

@cola119 cola119 added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 6, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 6, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59668/

@cola119 cola119 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Jun 7, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 7, 2024
@nodejs-github-bot nodejs-github-bot merged commit 479b8e5 into nodejs:main Jun 7, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 479b8e5

RafaelGSS pushed a commit that referenced this pull request Jun 7, 2024
@lukehaas @RafaelGSS
repl: fix await object patterns without values
e66eb37 
fix lint issue

PR-URL: #53331
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Jun 7, 2024
Merged
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
@lukehaas @eliphazbouye
repl: fix await object patterns without values
3d47a26 
fix lint issue

PR-URL: nodejs#53331
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@lukehaas @bmeck
repl: fix await object patterns without values
4770788 
fix lint issue

PR-URL: nodejs#53331
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@lukehaas @marco-ippolito
repl: fix await object patterns without values
3ecfcd8 
fix lint issue

PR-URL: #53331
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
@lukehaas @marco-ippolito
repl: fix await object patterns without values
092aa09 
fix lint issue

PR-URL: #53331
Reviewed-By: Ruben Bridgewater <[email protected]>
Reviewed-By: Kohei Ueno <[email protected]>
@marco-ippolito marco-ippolito mentioned this pull request Jul 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cola119 cola119 cola119 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Milestone
No milestone
4 participants
@lukehaas @cola119 @BridgeAR @nodejs-github-bot