src: print v8::OOMDetails::detail when it's available #53360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides a bit more information when V8 runs out of memory.
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
|
Could we add a test or the presence of the additional info is unreliable? |
legendecas
approved these changes
Jun 6, 2024
|
Most OOMDetails don't have a detail available. At the moment I can only find details present in wasm: https://source.chromium.org/chromium/chromium/src/+/main:v8/src/wasm/wasm-code-manager.cc;l=706?q=FatalProcessOutOfMemory |
github-actions
bot
removed
the
request-ci
joyeecheung
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/53360 ✔ Done loading data for nodejs/node/pull/53360 ----------------------------------- PR info ------------------------------------ Title src: print v8::OOMDetails::detail when it's available (#53360) Author Joyee Cheung (@joyeecheung) Branch joyeecheung:oom-details -> nodejs:main Labels c++, needs-ci Commits 1 - src: print v8::OOMDetails::detail when it's available Committers 1 - Joyee Cheung PR-URL: https://github.com/nodejs/node/pull/53360 Reviewed-By: Chengzhong Wu ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/53360 Reviewed-By: Chengzhong Wu -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 06 Jun 2024 09:07:02 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/53360#pullrequestreview-2102221857 ✘ This PR needs to wait 18 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-06-12T12:31:22Z: https://ci.nodejs.org/job/node-test-pull-request/59735/ - Querying data for job/node-test-pull-request/59735/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/9484561039 |
nodejs-github-bot
added
the
commit-queue-failed
debadree25
approved these changes
Jun 12, 2024
debadree25
added
author ready
nodejs-github-bot
removed
the
commit-queue
|
Landed in 5a19a9b |
targos
pushed a commit
that referenced
this pull request
Jun 20, 2024
This provides a bit more information when V8 runs out of memory. PR-URL: #53360 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
eliphazbouye
pushed a commit
to eliphazbouye/node
that referenced
this pull request
Jun 20, 2024
This provides a bit more information when V8 runs out of memory. PR-URL: nodejs#53360 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
This provides a bit more information when V8 runs out of memory. PR-URL: nodejs#53360 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
This provides a bit more information when V8 runs out of memory. PR-URL: #53360 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
marco-ippolito
pushed a commit
that referenced
this pull request
Jul 19, 2024
This provides a bit more information when V8 runs out of memory. PR-URL: #53360 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Debadree Chatterjee <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides a bit more information when V8 runs out of memory.