Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: only apply content-visibility on all.html #53510

Merged
merged 2 commits into from
Jun 19, 2024

Conversation

panva
Copy link
Member

@panva panva commented Jun 19, 2024

Refs: #40099 (comment)

content-visibility is the source of bad anchor scrolling behaviours in select browsers that support this rule. This change makes it only apply to the sections in the all.html docs page.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/nodejs-website

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 19, 2024
doc/api_assets/style.css Outdated Show resolved Hide resolved
Co-authored-by: Antoine du Hamel <[email protected]>
@panva panva added commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 19, 2024
@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 19, 2024
Copy link
Contributor

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLow
Copy link
Member

MoLow commented Jun 19, 2024

I suggest we get this out as fast as possible @nodejs/releasers

@ovflowd
Copy link
Member

ovflowd commented Jun 19, 2024

Feel free to fast-track this. Also indeed, releases if this could be patched on current live API docs (cc @nodejs/build)

@richardlau
Copy link
Member

Feel free to fast-track this. Also indeed, releases if this could be patched on current live API docs (cc @nodejs/build)

This cannot be patched on the current docs and would need new releases.

@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 67c19c2 into nodejs:main Jun 19, 2024
25 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 67c19c2

@panva panva deleted the doc-content-visibility branch June 19, 2024 17:22
targos pushed a commit that referenced this pull request Jun 20, 2024
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
eliphazbouye pushed a commit to eliphazbouye/node that referenced this pull request Jun 20, 2024
Refs: nodejs#40099
PR-URL: nodejs#53510
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
Refs: nodejs#40099
PR-URL: nodejs#53510
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
marco-ippolito pushed a commit that referenced this pull request Jul 19, 2024
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
@aduh95 aduh95 added the lts-watch-v18.x PRs that may need to be released in v18.x. label Nov 2, 2024
aduh95 pushed a commit that referenced this pull request Nov 7, 2024
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
aduh95 pushed a commit that referenced this pull request Nov 7, 2024
Refs: #40099
PR-URL: #53510
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Moshe Atlow <[email protected]>
Reviewed-By: Claudio Wunder <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. lts-watch-v18.x PRs that may need to be released in v18.x.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants