Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc, child_process: add esm snippets #53616

Merged
merged 5 commits into from
Sep 5, 2024
Merged

doc, child_process: add esm snippets #53616

merged 5 commits into from
Sep 5, 2024

Conversation

RedYetiDev
Copy link
Member

This PR adds ESM snippets to the documentation for node:child_process.

In addition to this, some snippets were modified for readability (message instead of m, etc)

@nodejs-github-bot nodejs-github-bot added child_process Issues and PRs related to the child_process subsystem. doc Issues and PRs related to the documentations. labels Jun 27, 2024
@RedYetiDev RedYetiDev mentioned this pull request Jul 9, 2024
Closed
@RedYetiDev RedYetiDev added the review wanted PRs that need reviews. label Jul 9, 2024
@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 19, 2024
@RedYetiDev
Copy link
Member Author

@atlowChemi could you re-review?

atlowChemi
atlowChemi approved these changes Aug 29, 2024
View reviewed changes
doc/api/child_process.md Outdated Show resolved Hide resolved
doc/api/child_process.md Outdated Show resolved Hide resolved
@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 4, 2024
@atlowChemi atlowChemi added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 5, 2024
@nodejs-github-bot nodejs-github-bot merged commit 0debdac into nodejs:main Sep 5, 2024
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0debdac

aduh95 pushed a commit that referenced this pull request Sep 12, 2024
@RedYetiDev @aduh95
doc, child_process: add esm snippets
5e081a1 
PR-URL: #53616
Reviewed-By: Chemi Atlow <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
child_process Issues and PRs related to the child_process subsystem. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. review wanted PRs that need reviews.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RedYetiDev @nodejs-github-bot @atlowChemi @Trott