Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor platform utility methods #53817

Merged
merged 1 commit into from
Jul 15, 2024
Merged

lib: refactor platform utility methods #53817

merged 1 commit into from
Jul 15, 2024

Conversation

danielbayley
Copy link
Contributor

Salvaging some of the cleanup work previously done in #53547, for fewer LOC, reuse of methods, and better consistency.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/loaders
  • @nodejs/net
  • @nodejs/url
  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Jul 11, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Jul 12, 2024 •
edited
Loading

Are these two separate commits (unrelated to one another), or should they be squashed during merge?

commit-queue-squash vs commit-queue-rebase

@aduh95
Copy link
Contributor

aduh95 commented Jul 12, 2024

b66edfa should be a separate PR IMO, can you remove it or revert it in this PR please?

@danielbayley
Copy link
Contributor Author

danielbayley commented Jul 12, 2024 •
edited
Loading

Are these two separate commits (unrelated to one another)

They’re very much related; I separated them just because one is focussed basically on DRYing up the platform methods, and the other on cleaning up the OSX references to match…

b66edfa should be a separate PR IMO, can you remove it or revert it in this PR please?

@RedYetiDev @aduh95 Done, and moved to #53820.

@danielbayley danielbayley mentioned this pull request Jul 12, 2024
Merged
mcollina
mcollina approved these changes Jul 12, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 12, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60276/

@RedYetiDev RedYetiDev removed their request for review July 13, 2024 15:04
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jul 14, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 14, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/60304/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 953abf4 into nodejs:main Jul 15, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 953abf4

@danielbayley danielbayley deleted the utility-platform-cleanup branch July 15, 2024 19:59
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@danielbayley @aduh95
lib: refactor platform utility methods
6debb36 
PR-URL: #53817
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
aduh95 pushed a commit that referenced this pull request Jul 16, 2024
@danielbayley @aduh95
lib: refactor platform utility methods
0a01abb 
PR-URL: #53817
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
@aduh95 aduh95 mentioned this pull request Jul 16, 2024
Merged
ehsankhfr pushed a commit to ehsankhfr/node that referenced this pull request Jul 18, 2024
@danielbayley @ehsankhfr
lib: refactor platform utility methods
aadaf03 
PR-URL: nodejs#53817
Reviewed-By: Matteo Collina <[email protected]>
Reviewed-By: Daeyeon Jeong <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RedYetiDev RedYetiDev RedYetiDev left review comments

@mcollina mcollina mcollina approved these changes

@Qard Qard Qard approved these changes

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@daeyeon daeyeon daeyeon approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@danielbayley @nodejs-github-bot @RedYetiDev @aduh95 @mcollina @Qard @jasnell @lpinca @daeyeon @marco-ippolito