Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add more details for localStorage and sessionStorage #53881

Merged
merged 27 commits into from
Sep 20, 2024
Merged

doc: add more details for localStorage and sessionStorage #53881

merged 27 commits into from
Sep 20, 2024

Conversation

Rekl0w
Copy link
Contributor

@Rekl0w Rekl0w commented Jul 17, 2024

doc: add more details for localStorage and sessionStorage

Releated #53871

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 17, 2024
mertcanaltin
mertcanaltin approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RedYetiDev
Copy link
Member

CC @cjihrig

RedYetiDev
RedYetiDev reviewed Jul 17, 2024
View reviewed changes
doc/api/globals.md Outdated Show resolved Hide resolved
RedYetiDev
RedYetiDev reviewed Jul 17, 2024
View reviewed changes
doc/api/globals.md Outdated Show resolved Hide resolved
doc/api/globals.md Outdated Show resolved Hide resolved
Rekl0w and others added 2 commits July 17, 2024 22:43
@Rekl0w @RedYetiDev
Update doc/api/globals.md
071dd6b 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
10aae0f 
Co-authored-by: Aviv Keller <[email protected]>
cjihrig
cjihrig reviewed Jul 18, 2024
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
doc/api/globals.md Outdated Show resolved Hide resolved
doc/api/globals.md Show resolved Hide resolved
@RedYetiDev
Copy link
Member

Please run make format-md when you get a change, It'll format the document.

@Rekl0w
Copy link
Contributor Author

Rekl0w commented Jul 19, 2024

I use windows, i can get help for formatting.

@Rekl0w
Copy link
Contributor Author

Rekl0w commented Jul 22, 2024

Any updates here ? @RedYetiDev

@mertcanaltin
Copy link
Member

mertcanaltin commented Jul 25, 2024 •
edited
Loading

I use windows, i can get help for formatting.

You can use vcbuild after installing the vcbuild lint command will work for you, if you encounter any problems, please feel free to write

in addition some information about windows is here: windows doc

mertcanaltin
mertcanaltin reviewed Jul 25, 2024
View reviewed changes
doc/api/globals.md Outdated Show resolved Hide resolved
@Rekl0w
Copy link
Contributor Author

Rekl0w commented Aug 12, 2024 •
edited
Loading

I used it but there are no changes in the files. @mertcanaltin

@mertcanaltin
Copy link
Member

I wonder if there is any warning message, what do you see as output

@Rekl0w
Copy link
Contributor Author

Rekl0w commented Aug 13, 2024

There is no warning message. I also tried an extension called markdownlint on VS Code, no diff.

@mertcanaltin
Copy link
Member

I have made an arrangement for you in my local, you can update it from here
mertcanaltin@ff78d56

@Rekl0w
Copy link
Contributor Author

Rekl0w commented Aug 15, 2024

Really appreciate that, thank you. @mertcanaltin

RedYetiDev
RedYetiDev reviewed Aug 16, 2024
View reviewed changes
Copy link
Member

@RedYetiDev RedYetiDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it still needs to be formatted, but content-wise LGTM (but I'm not a core collaborator)

@Rekl0w
Copy link
Contributor Author

Rekl0w commented Aug 19, 2024

Then it is up to you @cjihrig.

Rekl0w and others added 9 commits August 21, 2024 08:30
@Rekl0w @RedYetiDev
Update doc/api/globals.md
ba117c2 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
77fc563 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
314a62f 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
1bb4f50 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
8c2da93 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
683ee9f 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
5d6e9b6 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
7b497da 
Co-authored-by: Aviv Keller <[email protected]>
@Rekl0w @RedYetiDev
Update doc/api/globals.md
43ae345 
Co-authored-by: Aviv Keller <[email protected]>
RedYetiDev
RedYetiDev reviewed Aug 21, 2024
View reviewed changes
doc/api/globals.md Outdated Show resolved Hide resolved
cjihrig
cjihrig reviewed Aug 23, 2024
View reviewed changes
doc/api/globals.md Outdated Show resolved Hide resolved
doc/api/globals.md Outdated Show resolved Hide resolved
@RedYetiDev RedYetiDev added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Aug 23, 2024
@Rekl0w
Copy link
Contributor Author

Rekl0w commented Aug 23, 2024

I guess it is done now. @RedYetiDev @cjihrig

RedYetiDev
RedYetiDev reviewed Aug 26, 2024
View reviewed changes
doc/api/globals.md Outdated Show resolved Hide resolved
@cjihrig @RedYetiDev
Update doc/api/globals.md
20cf144 
Co-authored-by: Aviv Keller <[email protected]>
@RedYetiDev RedYetiDev mentioned this pull request Aug 30, 2024
Open
@Rekl0w
Copy link
Contributor Author

Rekl0w commented Sep 19, 2024

Any updates here ?

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 20, 2024
@nodejs-github-bot nodejs-github-bot merged commit 99433a2 into nodejs:main Sep 20, 2024
16 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 99433a2

@cjihrig cjihrig mentioned this pull request Sep 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@RedYetiDev RedYetiDev RedYetiDev left review comments

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Rekl0w @RedYetiDev @mertcanaltin @cjihrig @nodejs-github-bot @jasnell