Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: copyedit util doc #5399

Closed
wants to merge 1 commit into from
Closed

doc: copyedit util doc #5399

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 23, 2016

Add verbs to make sentence fragments less fragmentary.

/cc @nodejs/documentation

Add verbs to make sentence fragments less fragmentary.
@Trott Trott added doc Issues and PRs related to the documentations. lts-watch-v4.x labels Feb 23, 2016
@eljefedelrodeodeljefe
Copy link
Contributor

Immediate LGTM. Sounds much friendlier.

@kahwee
Copy link

kahwee commented Feb 24, 2016

I like this! LGTM

@mscdex mscdex added the util Issues and PRs related to the built-in util module. label Feb 24, 2016
@a0viedo
Copy link
Member

a0viedo commented Feb 24, 2016

LGTM

@Trott
Copy link
Member Author

Trott commented Feb 25, 2016

bump @nodejs/collaborators (I appreciate the existing LGTMs, but I believe I need at least one from an on-boarded collaborator to land.)

@cjihrig
Copy link
Contributor

cjihrig commented Feb 25, 2016

LGTM

1 similar comment
@silverwind
Copy link
Contributor

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Feb 25, 2016
Add verbs to make sentence fragments less fragmentary.

PR-URL: nodejs#5399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott
Copy link
Member Author

Trott commented Feb 25, 2016

Landed in 6e6ce09

@Trott Trott closed this Feb 25, 2016
rvagg pushed a commit that referenced this pull request Feb 27, 2016
Add verbs to make sentence fragments less fragmentary.

PR-URL: #5399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
rvagg pushed a commit that referenced this pull request Feb 27, 2016
Add verbs to make sentence fragments less fragmentary.

PR-URL: #5399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Mar 1, 2016
5 tasks
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
Add verbs to make sentence fragments less fragmentary.

PR-URL: #5399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 1, 2016
Add verbs to make sentence fragments less fragmentary.

PR-URL: #5399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 2, 2016
Add verbs to make sentence fragments less fragmentary.

PR-URL: #5399
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Roman Reiss <[email protected]>
@Trott Trott deleted the unstale branch January 13, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants