crypto: remove unnecessary buffer initialization #54046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
crypto
anonrig
force-pushed
the
fix-unnecessary-buffer-init
branch
from
c246990
to
16877cb
Compare
jasnell
approved these changes
Jul 25, 2024
github-actions
bot
removed
the
request-ci
anonrig
added
the
author ready
mertcanaltin
approved these changes
Jul 26, 2024
tniessen
reviewed
Jul 26, 2024
| if (outputEncoding && outputEncoding !== 'buffer') | ||
| return buf.toString(outputEncoding); | ||
| return buf; | ||
| return !outputEncoding || outputEncoding === 'buffer' ? Buffer.from('') : ''; |
There was a problem hiding this comment.
Is this faster than Buffer.alloc(0)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems unnecessary to initialize a Buffer for non-buffer output encodings and call toString() on an empty string. If I'm not mistaken, any encoding of an empty string, returns an empty string.