tools: add tsc checker #54069
Open
tools: add tsc checker #54069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
1ilsang
force-pushed
the
feat/typings-lint
branch
from
f5dce3f
to
3b44b03
Compare
|
Let's not vendor typescript, the diff is unnecessary big. |
|
Technically we already vendor TypeScript in https://github.com/nodejs/node/blob/main/test/fixtures/snapshot/typescript.js |
Unfortunately, We don't have Typescript declare files, so we can't check the declare file. 
Is this the way to do it? Any advice would be appreciated. Here is example PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I've noticed that the declare files are not being checked(#54063, #54064) properly.
So I'd like to add lint for those files.
AS-IS
None
TO-BE
If this PR is approved, I would also like to apply typescript-eslint(related #54065).
What do you think? thanks.