-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib,permission: support Buffer to permission.has #54104
lib,permission: support Buffer to permission.has #54104
Conversation
Review requested:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54104 +/- ##
==========================================
- Coverage 87.07% 87.06% -0.01%
==========================================
Files 643 643
Lines 181583 181588 +5
Branches 34886 34892 +6
==========================================
- Hits 158114 158103 -11
- Misses 16751 16758 +7
- Partials 6718 6727 +9
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Failures are related to nodejs/build#3848 |
Landed in 358ff74 |
PR-URL: #54104 Fixes: #54100 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Marco Ippolito <[email protected]>
Fixes: #54100