Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update required python version #54112

Closed
wants to merge 1 commit into from
Closed

Update required python version #54112

wants to merge 1 commit into from

Conversation

d3x0r
Copy link
Contributor

@d3x0r d3x0r commented Jul 30, 2024

Configure scripts use := operator now, which requires python 3.8.

File "tools/gyp/pylib/gyp/common.py", line 435
if CC := os.environ.get("CC_target") or os.environ.get("CC"):

@d3x0r
Update BUILDING.md
2ee07b5 
Configure scripts use := operator now, which requires python 3.8.

  File "tools/gyp/pylib/gyp/common.py", line 435
    if CC := os.environ.get("CC_target") or os.environ.get("CC"):
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jul 30, 2024
@lpinca
Copy link
Member

lpinca commented Jul 30, 2024

Python 3.6 is still officially supported

node/configure

Line 28 in f9f9a42

acceptable_pythons = ((3, 13), (3, 12), (3, 11), (3, 10), (3, 9), (3, 8), (3, 7), (3, 6))

I guess we should update that.

@RedYetiDev RedYetiDev added the python PRs and issues that require attention from people who are familiar with Python. label Aug 4, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Aug 13, 2024 •
edited
Loading

Hey, @d3x0r, are you still planning to add the parts that @lpinca mentioned?

FWIW there are also merge conflicts.

@RedYetiDev RedYetiDev mentioned this pull request Aug 13, 2024
Closed
@d3x0r
Copy link
Contributor Author

d3x0r commented Aug 13, 2024

I can't do much more than start this - if someone wants to start a new PR or take over this one that'd be better, I'm sure there's lots of small details I don't know about.

@RedYetiDev RedYetiDev self-assigned this Aug 13, 2024
@RedYetiDev
Copy link
Member

No worries! I'll update the required files later today

@RedYetiDev RedYetiDev mentioned this pull request Aug 13, 2024
Merged
@RedYetiDev
Copy link
Member

#54358 has all the changes needed. @d3x0r has been marked as a Co-Author.

@RedYetiDev
Copy link
Member

Closing in favor

@RedYetiDev RedYetiDev closed this Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

Assignees

@RedYetiDev RedYetiDev

Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@d3x0r @lpinca @RedYetiDev @nodejs-github-bot