-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
inspector: provide detailed network information to fix devtools frontend errors #54156
Conversation
fb6195c
to
d823d8a
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #54156 +/- ##
==========================================
- Coverage 87.07% 87.06% -0.01%
==========================================
Files 643 643
Lines 181582 181652 +70
Branches 34891 34910 +19
==========================================
+ Hits 158111 158157 +46
- Misses 16751 16767 +16
- Partials 6720 6728 +8
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM % one comment.
bc992d7
to
e02aaa7
Compare
Commit Queue failed- Loading data for nodejs/node/pull/54156 ✔ Done loading data for nodejs/node/pull/54156 ----------------------------------- PR info ------------------------------------ Title inspector: provide detailed network information to fix devtools frontend errors (#54156) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch cola119:fix-ni-frontend-error -> nodejs:main Labels c++, inspector, author ready, commit-queue-squash Commits 4 - inspector: provide detailed info to fix DevTools frontend errors - inspector: support `Network.Response.statusText` property - inspector: delete unused declarations in header file for cleanup - inspector: convert a header object to a simple string dictionary Committers 1 - cola119 <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54156 Reviewed-By: Chengzhong Wu <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54156 Reviewed-By: Chengzhong Wu <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 01 Aug 2024 06:29:33 GMT ✔ Approvals: 1 ✔ - Chengzhong Wu (@legendecas) (TSC): https://github.com/nodejs/node/pull/54156#pullrequestreview-2215047386 ✘ This PR needs to wait 76 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-02T22:33:18Z: https://ci.nodejs.org/job/node-test-pull-request/60840/ - Querying data for job/node-test-pull-request/60840/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10241284324 |
/cc @nodejs/inspector would you mind taking a look at this? |
Landed in 3616ace |
PR-URL: #54156 Reviewed-By: Chengzhong Wu <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
ref #53593 (comment)
This PR addresses and resolves specific errors occurring in the ChromeDevTools frontend, as reported at issues.chromium.org.
The error being fixed are as follows:
These errors occur because Node.js doesn't provide the necessary debug information (such as request/response headers and content type) to the frontend during network inspection. Without this information, the Chrome DevTools frontend cannot properly handle and display network requests, leading to the aforementioned errors. To resolve the issue, the change in this PR ensure that Node.js supplies the required debugging information to the frontend. Specifically,