meta: move one or more collaborators to emeritus #54210
Merged
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
meta
|
Ping @kuriyosh |
marco-ippolito
approved these changes
Aug 5, 2024
targos
approved these changes
Aug 5, 2024
MoLow
approved these changes
Aug 5, 2024
benjamingr
approved these changes
Aug 5, 2024
cola119
approved these changes
Aug 5, 2024
richardlau
approved these changes
Aug 5, 2024
RafaelGSS
approved these changes
Aug 5, 2024
lpinca
approved these changes
Aug 5, 2024
anonrig
approved these changes
Aug 6, 2024
tniessen
approved these changes
Aug 6, 2024
aduh95
added
author ready
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54210 ✔ Done loading data for nodejs/node/pull/54210 ----------------------------------- PR info ------------------------------------ Title meta: move one or more collaborators to emeritus (#54210) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/inactive-collaborators -> nodejs:main Labels doc, meta, author ready Commits 1 - meta: move one or more collaborators to emeritus Committers 1 - Node.js GitHub Bot <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54210 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54210 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 05 Aug 2024 04:11:24 GMT ✔ Approvals: 11 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218015027 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218064874 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218141960 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218215051 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218998438 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2219002204 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2219080522 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54210#pullrequestreview-2219371220 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2221359526 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2221575053 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2221696045 ✘ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10288656174 |
benjamingr
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54210 ✔ Done loading data for nodejs/node/pull/54210 ----------------------------------- PR info ------------------------------------ Title meta: move one or more collaborators to emeritus (#54210) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/inactive-collaborators -> nodejs:main Labels doc, meta, author ready Commits 1 - meta: move one or more collaborators to emeritus Committers 1 - Node.js GitHub Bot <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54210 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54210 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Mon, 05 Aug 2024 04:11:24 GMT ✔ Approvals: 11 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218015027 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218064874 ✔ - Moshe Atlow (@MoLow) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218141960 ✔ - Benjamin Gruenbaum (@benjamingr) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218215051 ✔ - Kohei Ueno (@cola119): https://github.com/nodejs/node/pull/54210#pullrequestreview-2218998438 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2219002204 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2219080522 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54210#pullrequestreview-2219371220 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2221359526 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2221575053 ✔ - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/54210#pullrequestreview-2221696045 ✘ GitHub CI is still running ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10289809120 |
|
@benjamingr retrying the CQ is only doomed to fail if we don't release nodejs/node-core-utils#838 first. That's done now, let's see if it goes through. |
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a3ff3e8 |
targos
pushed a commit
that referenced
this pull request
Aug 14, 2024
PR-URL: #54210 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Moshe Atlow <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]> Reviewed-By: Kohei Ueno <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was generated by the
find-inactive-collaborators.ymlworkflow.@nodejs/tsc Please follow up with the offboarding tasks.