-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
esm: modernize old tests #54368
esm: modernize old tests #54368
Conversation
Sorry I forgot to ask you that earlier, but the subsystem is actually wrong since it only touches the The instructions on how to do it: # first make sure you are on top of the right commit
git fetch https://github.com/nodejs/node.git bade48fc9662dd0a63f88a8a12d0c824f435276d
git reset FETCH_HEAD --hard
# amend the commit message
git commit --amend
# Force push to your branch
git push origin HEAD:modernize-old-esm-tests --force-with-lease Let me know if you prefer I do that for you. |
You might want to reopen the other PR btw, so the approval and the wait time do not reset. Let me know if you want me to push the correct commit over there instead. But it's also fine to use a new PR if that's what you prefer. |
bade48f
to
d0d6e25
Compare
@aduh95 no worries! Thanks for your support btw! |
No issues, it's probably my bad, I supsect my force-push to your branch might have caused the issues you were seeing. FWIW Sorry for the bike shedding, but |
d0d6e25
to
0aa2cde
Compare
@aduh95 no worries! Changed the commit message, again :) and about |
Apologies again, I realize only now there's indeed a copy paste issue with Jacob's email: Line 356 in a3ff3e8
I feel bad asking you again for a force push, but hopefully this time it's the last one: can you please add the missing |
Co-Authored-By: Jacob Smith <[email protected]>
0aa2cde
to
f3a94cd
Compare
I knew I was right :) no worries, pushed again! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54368 +/- ##
==========================================
- Coverage 87.10% 87.09% -0.02%
==========================================
Files 648 648
Lines 182216 182217 +1
Branches 34966 34955 -11
==========================================
- Hits 158720 158694 -26
- Misses 16787 16818 +31
+ Partials 6709 6705 -4 |
is anything missing from this PR? could it get merged? |
Landed in e4fdd0b |
Co-Authored-By: Jacob Smith <[email protected]> PR-URL: #54368 Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: James M Snell <[email protected]>
Doing a round of fast cleanup of old open and stalled PRs.
Making sure this PR is moving along addressing the comments in the original discussion.
I added the author of the original PR in the commit message.
Co-Authored-By: Jacob Smith