Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix capitalization in module.md #54488

Merged
merged 1 commit into from
Aug 23, 2024
Merged

doc: fix capitalization in module.md #54488

merged 1 commit into from
Aug 23, 2024

Conversation

shallow-beach
Copy link
Contributor

@shallow-beach shallow-beach commented Aug 21, 2024 •
edited
Loading

c/e

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. module Issues and PRs related to the module subsystem. labels Aug 21, 2024
@RedYetiDev
Copy link
Member

Hi! Could you amend your commit to follow the guidelines it needs to pass validation. In this case, something like doc: fix capitalization in module.md would work.

@shallow-beach shallow-beach changed the title Update modules.md doc: fix capitalization in module.md Aug 21, 2024
@RedYetiDev
Copy link
Member

RedYetiDev commented Aug 21, 2024 •
edited
Loading

You've updated the title, but you still need to update the commit via git commit --amend "doc: fix capitalization in module.md" followed by git push --force

@shallow-beach
Copy link
Contributor Author

shallow-beach commented Aug 21, 2024 •
edited
Loading

You've updated the title, but you still need to update the commit via git commit --amend "doc: fix capitalization in module.md" followed by git push --force

oo wee, my first --amend+push --force. thanks for bearing with me. did i get it this time?

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 22, 2024
@lpinca lpinca added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Fast-track has been requested by @lpinca. Please 👍 to approve.

@jakecastelli jakecastelli added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 23, 2024
@nodejs-github-bot nodejs-github-bot merged commit a21af4b into nodejs:main Aug 23, 2024
22 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a21af4b

@shallow-beach shallow-beach deleted the patch-1 branch August 23, 2024 00:54
RafaelGSS pushed a commit that referenced this pull request Aug 25, 2024
@shallow-beach @RafaelGSS
doc: fix capitalization in module.md
0f2b7ec 
PR-URL: #54488
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Aug 25, 2024
Merged
RafaelGSS pushed a commit that referenced this pull request Aug 30, 2024
@shallow-beach @RafaelGSS
doc: fix capitalization in module.md
61affd7 
PR-URL: #54488
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Ulises Gascón <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Jake Yuesong Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@aduh95 aduh95 aduh95 approved these changes

@jakecastelli jakecastelli jakecastelli approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. module Issues and PRs related to the module subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@shallow-beach @nodejs-github-bot @RedYetiDev @lpinca @UlisesGascon @aduh95 @jakecastelli