test: fix test-process-load-env-file when path contains '
#54511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the repo is cloned on a path that contains a quote, the test should not fail.
nodejs-github-bot
added
needs-ci
anonrig
approved these changes
Aug 22, 2024
aduh95
added
author ready
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54511 +/- ##
==========================================
- Coverage 87.34% 87.34% -0.01%
==========================================
Files 649 649
Lines 182524 182524
Branches 35026 35030 +4
==========================================
- Hits 159420 159418 -2
- Misses 16373 16377 +4
+ Partials 6731 6729 -2 |
This comment was marked as outdated.
This comment was marked as outdated.
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/54511 ✔ Done loading data for nodejs/node/pull/54511 ----------------------------------- PR info ------------------------------------ Title test: fix `test-process-load-env-file` when path contains `'` (#54511) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:more-robust-process-load-env-test -> nodejs:main Labels test, author ready, needs-ci Commits 1 - test: fix `test-process-load-env-file` when path contains `'` Committers 1 - Antoine du Hamel <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54511 Reviewed-By: Yagiz Nizipli <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54511 Reviewed-By: Yagiz Nizipli <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 22 Aug 2024 20:08:19 GMT ✔ Approvals: 1 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/54511#pullrequestreview-2255562343 ✘ This PR needs to wait 11 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-08-23T21:23:43Z: https://ci.nodejs.org/job/node-test-pull-request/61393/ - Querying data for job/node-test-pull-request/61393/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10611625567 |
nodejs-github-bot
added
the
commit-queue-failed
jasnell
approved these changes
Aug 31, 2024
aduh95
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in a75e3df |
aduh95
added a commit
that referenced
this pull request
Sep 12, 2024
If the repo is cloned on a path that contains a quote, the test should not fail. PR-URL: #54511 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the repo is cloned on a path that contains a quote, the test should not fail.
For good measure, I used a test path with "odd" chars so we're making sure it works everywhere.