src: switch crypto APIs to use Maybe<void> #54775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
anonrig
approved these changes
Sep 4, 2024
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
approved these changes
Sep 4, 2024
jasnell
changed the title
|
I expanded this out to include more cases. |
This comment was marked as outdated.
This comment was marked as outdated.
anonrig
approved these changes
Sep 5, 2024
This comment was marked as outdated.
This comment was marked as outdated.
addaleax
reviewed
Sep 5, 2024
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
crypto-additionalconfig-justvoid
branch
from
aa6a494
to
a0c36cb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
added
the
author ready
jasnell
force-pushed
the
crypto-additionalconfig-justvoid
branch
from
a0c36cb
to
5ed3a1d
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
crypto-additionalconfig-justvoid
branch
from
5ed3a1d
to
329e625
Compare
This comment was marked as outdated.
This comment was marked as outdated.
jasnell
force-pushed
the
crypto-additionalconfig-justvoid
branch
from
329e625
to
a2b96df
Compare
|
CI: https://ci.nodejs.org/job/node-test-pull-request/62343/ 💛 finally! |
jasnell
added a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54775 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
|
Landed in 08eccaf |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54775 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR-URL: #54775 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR-URL: #54775 Reviewed-By: Yagiz Nizipli <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.