test: reduce fs calls in test-fs-existssync-false #54815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54815 +/- ##
=======================================
Coverage 87.89% 87.89%
=======================================
Files 651 651
Lines 183364 183364
Branches 35714 35717 +3
=======================================
Hits 161171 161171
Misses 15465 15465
Partials 6728 6728 |
jasnell
reviewed
Sep 7, 2024
jasnell
approved these changes
Sep 7, 2024
github-actions
bot
removed
the
request-ci
lpinca
approved these changes
Sep 7, 2024
lpinca
added
the
commit-queue
anonrig
force-pushed
the
test-fs-existssync
branch
from
05dea1e
to
03e1ba5
Compare
jasnell
added
the
author ready
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/54815 ✔ Done loading data for nodejs/node/pull/54815 ----------------------------------- PR info ------------------------------------ Title test: reduce fs calls in test-fs-existssync-false (#54815) Author Yagiz Nizipli <[email protected]> (@anonrig) Branch anonrig:test-fs-existssync -> nodejs:main Labels fs, test, author ready, needs-ci Commits 1 - test: reduce fs calls in test-fs-existssync-false Committers 1 - Yagiz Nizipli <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54815 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54815 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last approving review: ⚠ - test: reduce fs calls in test-fs-existssync-false ℹ This PR was created on Fri, 06 Sep 2024 16:49:44 GMT ✔ Approvals: 2 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54815#pullrequestreview-2288365026 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54815#pullrequestreview-2288368554 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-07T19:58:56Z: https://ci.nodejs.org/job/node-test-pull-request/62117/ ⚠ Commits were pushed after the last Full PR CI run: ⚠ - test: reduce fs calls in test-fs-existssync-false - Querying data for job/node-test-pull-request/62117/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10797440128 |
nodejs-github-bot
added
the
commit-queue-failed
RedYetiDev
removed
the
commit-queue-failed
cjihrig
approved these changes
Sep 11, 2024
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in cc780dd |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54815 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR-URL: #54815 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
aduh95
pushed a commit
that referenced
this pull request
Sep 13, 2024
PR-URL: #54815 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduces filesystem calls on a fs test.