test: fix Windows async-context-frame memory failure #54823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qard
added
test
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54823 +/- ##
==========================================
- Coverage 87.62% 87.61% -0.01%
==========================================
Files 650 650
Lines 182997 182997
Branches 35415 35419 +4
==========================================
- Hits 160348 160341 -7
- Misses 15918 15924 +6
- Partials 6731 6732 +1 |
|
I canceled that run to limit what is running on CI right now. I think there are too many concurrent test runs going causing things to fail out. Trying to get things untangled. Will start it again once things appear more stable. |
|
Ok restarted CI. Some of the other tests may still flake out until this is rebased on tip of |
RedYetiDev
reviewed
Sep 7, 2024
Comment on lines
+45
to
+46
| // TODO(qard): I think high concurrency causes memory problems on Windows | ||
| // concurrency: tests.length |
There was a problem hiding this comment.
Suggested change
| // TODO(qard): I think high concurrency causes memory problems on Windows | |
| // concurrency: tests.length | |
| // TODO(qard): I think high concurrency causes memory problems on Windows. | |
| // concurrency: tests.length |
|
CI looks good! Let's go with this. |
jasnell
approved these changes
Sep 7, 2024
|
Thanks for managing the CI on that! Sorry for the trouble. 😅 |
lpinca
approved these changes
Sep 7, 2024
|
Can we also revert 407b61c? |
jakecastelli
approved these changes
Sep 7, 2024
jasnell
added
author ready
RafaelGSS
approved these changes
Sep 8, 2024
|
Fast-track has been requested by @jasnell. Please 👍 to approve. |
|
Requesting fast-track in order to help improve CI stability. |
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/54823 ✔ Done loading data for nodejs/node/pull/54823 ----------------------------------- PR info ------------------------------------ Title test: fix Windows async-context-frame memory failure (#54823) Author Stephen Belanger <[email protected]> (@Qard) Branch Qard:fix-async-context-frame-window-failure -> nodejs:main Labels test, fast-track, author ready, async_local_storage Commits 1 - test: fix Windows async-context-frame memory failure Committers 1 - Stephen Belanger <[email protected]> PR-URL: https://github.com/nodejs/node/pull/54823 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/54823 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 06 Sep 2024 21:20:38 GMT ✔ Approvals: 4 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/54823#pullrequestreview-2287302578 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/54823#pullrequestreview-2287457244 ✔ - Jake Yuesong Li (@jakecastelli): https://github.com/nodejs/node/pull/54823#pullrequestreview-2287489551 ✔ - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/54823#pullrequestreview-2288434091 ℹ This PR is being fast-tracked ✘ This PR needs to wait 17 more hours to land (or 0 hours if there is 1 more approval (👍) of the fast-track request from collaborators). ✔ Last GitHub CI successful ℹ Last Full PR CI on 2024-09-07T00:04:28Z: https://ci.nodejs.org/job/node-test-pull-request/62086/ - Querying data for job/node-test-pull-request/62086/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/10756651585 |
jasnell
removed
the
commit-queue-failed
jakecastelli
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in e1e312d |
aduh95
pushed a commit
that referenced
this pull request
Sep 12, 2024
PR-URL: #54823 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Jake Yuesong Li <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible alternative to #54818 to fix the issue with AsyncContextFrame tests crashing with memory errors on Windows. I suspect we're just spinning up too much stuff and eating all the memory.
cc @nodejs/diagnostics