test_runner: detect only tests when --test is not used #54881
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
added
the
semver-major
|
Review requested:
|
nodejs-github-bot
added
needs-ci
MoLow
reviewed
Sep 10, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #54881 +/- ##
==========================================
- Coverage 88.07% 88.06% -0.01%
==========================================
Files 651 651
Lines 183409 183409
Branches 35826 35825 -1
==========================================
- Hits 161529 161514 -15
- Misses 15142 15151 +9
- Partials 6738 6744 +6
|
|
Should the documentation be updated accordingly? (I'm not sure how this is currently documented) |
This commit updates the way the test runner processes 'only' tests when node:test files are run without the --test CLI. This is a breaking change.
cjihrig
added
the
commit-queue-squash
|
CI: https://ci.nodejs.org/job/node-test-pull-request/62370/ 🟢 A rare all green CI that was not resumed. |
|
@MoLow (and another TSC member since this is semver-major) PTAL. |
cjihrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in dbaef33 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the way the test runner processes 'only' tests when node:test files are run without the - test CLI.
The first two commits here are from #54832. Please ignore them while reviewing. The third commit is a breaking change.I was going to wait to open this PR until #54832 landed, but it's taking longer than expected because of CI flakiness, so I figured I would get the 48 hour clock started on this change.