Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix broken Android building link #54922

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

nikwen
Copy link
Contributor

@nikwen nikwen commented Sep 13, 2024

The old link is broken.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem. labels Sep 13, 2024
@nikwen nikwen changed the title docs: fix broken Android building link doc: fix broken Android building link Sep 13, 2024
@nikwen
Copy link
Contributor Author

nikwen commented Sep 13, 2024

Fixed the commit message!

@RedYetiDev RedYetiDev added build Issues and PRs related to build files or the CI. android Issues and PRs related to the android platform. labels Sep 13, 2024
@nikwen
Copy link
Contributor Author

nikwen commented Sep 13, 2024

Thanks for the reviews, everyone! Just noticed the link was also used in one other place, so I fixed that, too.

@lpinca lpinca added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Sep 14, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 15, 2024
@nodejs-github-bot nodejs-github-bot merged commit 4c0ad1f into nodejs:main Sep 15, 2024
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 4c0ad1f

RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
PR-URL: #54922
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
@RafaelGSS RafaelGSS mentioned this pull request Sep 16, 2024
RafaelGSS pushed a commit that referenced this pull request Sep 16, 2024
PR-URL: #54922
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
PR-URL: #54922
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
RafaelGSS pushed a commit that referenced this pull request Sep 17, 2024
PR-URL: #54922
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Xuguang Mei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Issues and PRs related to the android platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. process Issues and PRs related to the process subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants