Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: allow options for v8 testing #5502

Closed
wants to merge 1 commit into from
Closed

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Mar 1, 2016

Checklist

make test passes

Affected core subsystem(s)

v8

Description of change

Allow extra options when testing v8 in Node tree (see nodejs/build#199 for more details). The extra options can be set by setting them in 8_EXTRA_TEST_OPTIONS.

I've found this is needed while investigating #5263 will be generally useful. In particular for the CI job I want to use progress=dots instead of the more verbose default output

Allow extra options when testing v8 in Node tree
@mscdex mscdex added the test Issues and PRs related to the tests. label Mar 1, 2016
@bnoordhuis
Copy link
Member

LGTM although I don't really see why you'd need V8_EXTRA_TEST_OPTIONS when V8_TEST_OPTIONS exists as well.

@mhdawson
Copy link
Member Author

mhdawson commented Mar 1, 2016

I tried with just V8_TEST_OPTIONS, but it was not additive. When V8_TEST_OPTIONS was specified in the environment the --noi18n was not added.

@mhdawson mhdawson self-assigned this Mar 1, 2016
@mhdawson
Copy link
Member Author

mhdawson commented Mar 1, 2016

@mhdawson
Copy link
Member Author

mhdawson commented Mar 1, 2016

Issues in CI look like infra issue (timeout on ARM), win2015 compile job failed even thought it looks like it was successful:

mhdawson added a commit that referenced this pull request Mar 1, 2016
Allow extra options when testing v8 in Node tree

PR-URL: #5502
Reviewed-By: Ben Noordhuis <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented Mar 1, 2016

Landed as 32a2a60

@mhdawson mhdawson closed this Mar 1, 2016
Fishrock123 pushed a commit that referenced this pull request Mar 2, 2016
Allow extra options when testing v8 in Node tree

PR-URL: #5502
Reviewed-By: Ben Noordhuis <[email protected]>
@mhdawson mhdawson deleted the v8tests branch March 15, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants