Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: use env strings to create sqlite results #55785

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

src: use env strings to create sqlite results #55785

wants to merge 1 commit into from
+7 −6

Conversation

targos
Copy link
Member

@targos targos commented Nov 8, 2024

No description provided.

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Nov 8, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.41%. Comparing base (a094a81) to head (e5f4e8a).
Report is 22 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #55785   +/-   ##
=======================================
  Coverage   88.40%   88.41%           
=======================================
  Files         654      654           
  Lines      187757   187758    +1     
  Branches    36134    36130    -4     
=======================================
+ Hits       165990   165999    +9     
+ Misses      15007    14997   -10     
- Partials     6760     6762    +2
Files with missing lines Coverage Δ
src/node_sqlite.cc 81.86% <100.00%> (+0.03%) ⬆️

... and 28 files with indirect coverage changes

@anonrig
Copy link
Member

anonrig commented Nov 8, 2024

@targos I always wanted to ask this. Historically we always did this, but what's the purpose of such change?

@targos
Copy link
Member Author

targos commented Nov 9, 2024

Performance? Strings that are used more than once don't need to be recreated over and over again

@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/63524/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@targos @anonrig @nodejs-github-bot @benjamingr @lpinca @richardlau