Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add missing documentation for PerformanceObserver.prototype.takeRecords() #55786

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Nov 8, 2024

The PR add missing documentation for PerformanceObserver.prototype.takeRecords(), which landed in v16.0.0 with PerformanceObserver.supportedEntryTypes

confirmed by the release v16.0.0 and impl PR #37136

see also mdn documentation and specification

Fixes: #55779

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API. labels Nov 8, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review November 8, 2024 16:34
@RedYetiDev
Copy link
Member

Hi! Can you please amend your commit to follow the guidelines? It's a bit too long.

@skyclouds2001
Copy link
Contributor Author

Hi! Can you please amend your commit to follow the guidelines? It's a bit too long.

Sure!

@skyclouds2001 skyclouds2001 force-pushed the fix-55779-PerformanceObserver-takeRecords branch from d379b7a to 04c1d1f Compare November 8, 2024 22:53
@skyclouds2001
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. perf_hooks Issues and PRs related to the implementation of the Performance Timing API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing documentaion for PerformanceObserver.prototype.takeRecords() of perf_hooks module
3 participants