Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix v8 armv6 run-time detection #559

Merged
merged 3 commits into from
Jan 22, 2015

Conversation

bnoordhuis
Copy link
Member

The elf_platform suffix in /proc/cpuinfo moved to the model name field
in Linux 3.8.

Out-of-tree patch pending https://codereview.chromium.org/867713003/

Fixes: iojs#283

R=@indutny @silverwind @wilson0x4d

https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/99/

@indutny
Copy link
Member

indutny commented Jan 22, 2015

LGTM if it works

The elf_platform suffix in /proc/cpuinfo moved to the model name field
in Linux 3.8.

Out-of-tree patch pending https://codereview.chromium.org/867713003/

Fixes: nodejs#283
PR-URL: nodejs#559
Reviewed-By: Fedor Indutny <[email protected]>
VFPv3 is ARMv7-only, enabling it for ARMv6 is therefore always wrong.
Mea culpa, I do believe I'm the original author of that change.

Fixes: nodejs#283
PR-URL: nodejs#559
Reviewed-By: Fedor Indutny <[email protected]>
Remove the configure check, the flag was dropped in V8 3.28.

PR-URL: nodejs#559
Reviewed-By: Fedor Indutny <[email protected]>
@bnoordhuis bnoordhuis merged commit c6cd460 into nodejs:v1.x Jan 22, 2015
@bnoordhuis bnoordhuis deleted the fix-issue-283 branch January 22, 2015 22:12
misterdjules pushed a commit to misterdjules/node that referenced this pull request Mar 30, 2015
Port 297cadb from io.js.

Original commit message:

  The elf_platform suffix in /proc/cpuinfo moved to the model name field
  in Linux 3.8.

  Out-of-tree patch pending https://codereview.chromium.org/867713003/

  Fixes: nodejs/node#283
  PR-URL: nodejs/node#559
  Reviewed-By: Fedor Indutny <[email protected]>
misterdjules pushed a commit to misterdjules/node that referenced this pull request Mar 30, 2015
Port 7d9d756 from io.js.

Original commit message:

  VFPv3 is ARMv7-only, enabling it for ARMv6 is therefore always wrong.
  Mea culpa, I do believe I'm the original author of that change.

  Fixes: nodejs/node#283
  PR-URL: nodejs/node#559
  Reviewed-By: Fedor Indutny <[email protected]>
misterdjules pushed a commit to misterdjules/node that referenced this pull request Mar 30, 2015
Port c6cd460 from io.js.

Original commit message:

  Remove the configure check, the flag was dropped in V8 3.28.

  PR-URL: nodejs/node#559
  Reviewed-By: Fedor Indutny <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants