test: skip cluster-disconnect-race on Windows #5621
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
cluster
|
Yes, process.platfrom is 'win32' for all Windows version (see https://nodejs.org/api/process.html#process_process_platform). Change LGTM. CI run: https://ci.nodejs.org/job/node-test-pull-request/1895/ |
|
LGTM |
|
Okay, so the CI run had two failures, the first one seems to be a git connection error, and the second one is two test failures on Windows, test-dgram-multicast-multi-process.js and test-dns.js, which are presumably unrelated to this test. Assuming those failures can be ignored, it looks like this PR is good to go. |
jasnell
pushed a commit
that referenced
this pull request
Mar 16, 2016
PR-URL: #5621 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexis Campailla <[email protected]>
|
Landed in v0.12-staging in ab907eb |
4 tasks
jBarz
pushed a commit
to ibmruntimes/node
that referenced
this pull request
Nov 4, 2016
PR-URL: nodejs/node#5621 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Alexis Campailla <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
test (or a benchmark) included?
existing APIs, or introduces new ones)?
Affected core subsystem(s)
test
Description of change
See issue #5603 .
Skips simple/cluster-disconnect-race on Windows. This was already done in #4457 for V4, but the fix is slightly different for v0.12.
@rvagg presumably
process.platform === 'win32'covers 64bit as well as 32bit windows?