Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in synchronous randomBytes example #5781

Closed
wants to merge 1 commit into from
Closed

Typo in synchronous randomBytes example #5781

wants to merge 1 commit into from

Conversation

WebReflection
Copy link
Contributor

The string template was closed after ${buf.length} causing a syntax error within the example.

The string template was closed after `${buf.length}` causing a syntax error within the example.
@r-52 r-52 added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. labels Mar 18, 2016
@targos
Copy link
Member

targos commented Mar 18, 2016

LGTM

@benjamingr
Copy link
Member

LGTM. Thanks Andrea.

@cjihrig
Copy link
Contributor

cjihrig commented Mar 18, 2016

LGTM

@WebReflection
Copy link
Contributor Author

@benjamingr this is probably the smallest/easiest PR I've ever made so no problems at all ;-)

@jasnell
Copy link
Member

jasnell commented Mar 18, 2016

LGTM

jasnell pushed a commit that referenced this pull request Mar 18, 2016
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
@jasnell
Copy link
Member

jasnell commented Mar 18, 2016

Landed in ac6af73.
I fixed up the commit log message so that it conforms to our style guidelines.
Thank you!

@jasnell jasnell closed this Mar 18, 2016
@WebReflection
Copy link
Contributor Author

apologies I haven't fully followed the commit style guide. thanks for merging it

@jasnell
Copy link
Member

jasnell commented Mar 18, 2016

No worries :-) It's simple to fix. Really appreciate the contribution!

MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Fishrock123 pushed a commit that referenced this pull request Mar 22, 2016
The string template was closed after `${buf.length}`
causing a syntax error within the example.

PR-URL: #5781
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Benjamin Gruenbaum <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants