test: split out hints from test-dns #5992
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A few of the hints tests were flaky in CI on pi2-raspbian-wheezy. Moving them to their own file fixes it. It could be that there is an unnoticed interaction with other tests in the file, or it could be that there is a cumulative threshold on some resource that is reached that causes Pi2 to sometimes stall out. (The test was timing out.) Fixes: nodejs#5554
Trott
added
dns
|
Stress test showing current version is flaky on master: https://ci.nodejs.org/job/node-stress-single-test/577/nodes=pi2-raspbian-wheezy/console Stress test for this version which will hopefully show it to be not flaky (but should certainly show it to be more reliable): https://ci.nodejs.org/job/node-stress-single-test/578/nodes=pi2-raspbian-wheezy/console |
|
Closing. More reliable approach coming in a little bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
make -j8 test(UNIX) orvcbuild test nosign(Windows) pass withthis change (including linting)?
Affected core subsystem(s)
test, dns
Description of change
A few of the hints tests were flaky in CI on pi2-raspbian-wheezy. Moving
them to their own file fixes it. It could be that there is an unnoticed
interaction with other tests in the file, or it could be that there is a
cumulative threshold on some resource that is reached that causes Pi2 to
sometimes stall out. (The test was timing out.)
Fixes: #5554