Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: cherry-pick 1ef7487b from v8 upstream #6218

Closed
wants to merge 1 commit into from

Commits on Apr 18, 2016

  1. deps: cherry-pick 1ef7487b from v8 upstream

    Original commit message:
    
         Improved diagnostic message for JS heap out of memory
    
         This patch replaces the unused 'take_snapshot' parameter on
         FatalProcessOutOfMemory() with a 'is_heap_oom' parameter.
         The parameter is set to true on error paths where the
         JS heap is out of memory, as distinct from a malloc()
         failure i.e. process out of memory.  The message output to
         stderr or passed to embedding applications via FatalErrorCallback
         is 'Javascript heap out of memory' rather than
         'process out of memory'.
    
         BUG=
    
         [email protected], [email protected], [email protected]
    
         Review URL: https://codereview.chromium.org/1873443002
    
         Cr-Commit-Position: refs/heads/master@{nodejs#35431}
    
    We'd like this in 6.x to help with diagnosing customer problems.
    It provides a better message on OOM so that it is easier to
    be able to tell whether the OOM was due to heap exhaustion
    or running out of native memory.
    mhdawson committed Apr 18, 2016
    Configuration menu
    Copy the full SHA
    98826b3 View commit details
    Browse the repository at this point in the history