Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7 #6402

Closed
wants to merge 1 commit into from
Closed

build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7 #6402

wants to merge 1 commit into from

Conversation

ChALkeR
Copy link
Member

@ChALkeR ChALkeR commented Apr 26, 2016 •
edited
Loading

Ref: #5731.

We currently target 10.5.
Libuv is going to drop 10.6 in v2: libuv/libuv#758.

Note that OS X versions 10.5-10.8 are not supported by Apple anymore and do not receive security patches.

Note that we don't state supported OS X versions anywhere, and the only version tested at CI is 10.10. Ref: nodejs/build#367.

/cc @bnoordhuis, @ofrobots, @jbergstroem, @nodejs/ctc

@ofrobots
Copy link
Contributor

LGTM.

@evanlucas
Copy link
Contributor

LGTM

@bnoordhuis
Copy link
Member

Awesome-looking patch. LGTM!

@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 26, 2016

@jasnell Any way to get this in?

@cjihrig
Copy link
Contributor

cjihrig commented Apr 26, 2016

LGTM

@ChALkeR
build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7
79965fa 
Ref: nodejs/build#367

libuv is going to drop 10.6 in v2.
Ref: libuv/libuv#758

OS X versions below 10.9 are not supported by Apple anymore and do not
receive security patches.

PR-URL: nodejs#6402
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
@ChALkeR ChALkeR mentioned this pull request Apr 26, 2016
Closed
@jasnell
Copy link
Member

jasnell commented Apr 26, 2016

Sigh... lol... yes, can get this one in

@indutny
Copy link
Member

indutny commented Apr 26, 2016

LGTM

1 similar comment
@MylesBorins
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

jasnell commented Apr 26, 2016

Landing in master and will pull it back

@ChALkeR ChALkeR added semver-major PRs that contain breaking changes and should be released in the next major version. build Issues and PRs related to build files or the CI. macos Issues and PRs related to the macOS platform / OSX. labels Apr 26, 2016
@Fishrock123 Fishrock123 added this to the 6.0.0 milestone Apr 26, 2016
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@ChALkeR @jasnell
build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7
204f3a8 
Refs: nodejs/build#367

libuv is going to drop 10.6 in v2.
Ref: libuv/libuv#758

OS X versions below 10.9 are not supported by Apple anymore and do not
receive security patches.

PR-URL: #6402
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@jasnell
Copy link
Member

jasnell commented Apr 26, 2016

Landed in 204f3a8

@jasnell jasnell closed this Apr 26, 2016
@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 26, 2016 •
edited
Loading

@jasnell Argh, I made a mistake in the commit message. The first ref should have been #5731. It's not critical, though, you can ignore that.

Sorry for that.

jasnell pushed a commit that referenced this pull request Apr 26, 2016
@ChALkeR @jasnell
build: Bump MACOSX_DEPLOYMENT_TARGET to 10.7
ce864ef 
Refs: nodejs/build#367

libuv is going to drop 10.6 in v2.
Ref: libuv/libuv#758

OS X versions below 10.9 are not supported by Apple anymore and do not
receive security patches.

PR-URL: #6402
Reviewed-By: Ali Ijaz Sheikh <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Fedor Indutny <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
jasnell added a commit that referenced this pull request Apr 26, 2016
@jasnell
2016-04-26, Version 6.0.0 (Current) Release
37f2f03 
The following significant (semver-major) changes have been made since the
previous Node v5.0.0 release.

* Buffer
  * New Buffer constructors have been added
    [#4682](#4682)
  * Previously deprecated Buffer APIs are removed
    [#5048](#5048),
    [#4594](#4594)
  * Improved error handling [#4514](#4514)
* Cluster
  * Worker emitted as first argument in 'message' event
    [#5361](#5361).
* Crypto
  * Improved error handling [#3100](#3100),
    [#5611](#5611)
  * Simplified Certificate class bindings
    [#5382](#5382)
  * Improved control over FIPS mode
    [#5181](#5181)
  * pbkdf2 digest overloading is deprecated
    [#4047](#4047)
* Dependencies
  * Reintroduce shared c-ares build support
    [#5775](#5775).
  * V8 updated to 5.0.71.31 [#6111](#6111).
* DNS
  * Add resolvePtr API to query plain DNS PTR records
    [#4921](#4921).
* Domains
  * Clear stack when no error handler
  [#4659](#4659).
* File System
  * The `fs.realpath()` and `fs.realpathSync()` methods have been updated
    to use a more efficient libuv implementation. This change includes the
    removal of the `cache` argument and the method can throw new errors
    [#3594](#3594)
  * FS apis can now accept and return paths as Buffers
    [#5616](#5616).
  * Error handling and type checking improvements
    [#5616](#5616),
    [#5590](#5590),
    [#4518](#4518),
    [#3917](#3917).
  * fs.read's string interface is deprecated
    [#4525](#4525)
* HTTP
  * 'clientError' can now be used to return custom errors from an
    HTTP server [#4557](#4557).
* Modules
  * Current directory is now prioritized for local lookups
    [#5689](#5689)
  * Symbolic links are preserved when requiring modules
    [#5950](#5950)
* Net
  * DNS hints no longer implicitly set
    [#6021](#6021).
  * Improved error handling and type checking
    [#5981](#5981),
    [#5733](#5733),
    [#2904](#2904)
* OS X
  * MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7
    [#6402](#6402).
* Path
  * Improved type checking [#5348](#5348).
* Process
  * Introduce process warnings API
    [#4782](#4782).
  * Throw exception when non-function passed to nextTick
    [#3860](#3860).
* Readline
  * Emit key info unconditionally
    [#6024](#6024)
* REPL
  * Assignment to `_` will emit a warning.
    [#5535](#5535)
* Timers
  * Fail early when callback is not a function
    [#4362](#4362)
* TLS
  * Rename 'clientError' to 'tlsClientError'
    [#4557](#4557)
  * SHA1 used for sessionIdContext
    [#3866](#3866)
* TTY
  * Previously deprecated setRawMode wrapper is removed
    [#2528](#2528).
* Util
  * Changes to Error object formatting
    [#4582](#4582).
* Windows
  * Windows XP and Vista are no longer supported
    [#5167](#5167),
    [#5167](#5167).
jasnell added a commit that referenced this pull request Apr 26, 2016
@jasnell
2016-04-26, Version 6.0.0 (Current) Release
ce3e3c5 
The following significant (semver-major) changes have been made since the
previous Node v5.0.0 release.

* Buffer
  * New Buffer constructors have been added
    [#4682](#4682)
  * Previously deprecated Buffer APIs are removed
    [#5048](#5048),
    [#4594](#4594)
  * Improved error handling [#4514](#4514)
* Cluster
  * Worker emitted as first argument in 'message' event
    [#5361](#5361).
* Crypto
  * Improved error handling [#3100](#3100),
    [#5611](#5611)
  * Simplified Certificate class bindings
    [#5382](#5382)
  * Improved control over FIPS mode
    [#5181](#5181)
  * pbkdf2 digest overloading is deprecated
    [#4047](#4047)
* Dependencies
  * Reintroduce shared c-ares build support
    [#5775](#5775).
  * V8 updated to 5.0.71.31 [#6111](#6111).
* DNS
  * Add resolvePtr API to query plain DNS PTR records
    [#4921](#4921).
* Domains
  * Clear stack when no error handler
  [#4659](#4659).
* File System
  * The `fs.realpath()` and `fs.realpathSync()` methods have been updated
    to use a more efficient libuv implementation. This change includes the
    removal of the `cache` argument and the method can throw new errors
    [#3594](#3594)
  * FS apis can now accept and return paths as Buffers
    [#5616](#5616).
  * Error handling and type checking improvements
    [#5616](#5616),
    [#5590](#5590),
    [#4518](#4518),
    [#3917](#3917).
  * fs.read's string interface is deprecated
    [#4525](#4525)
* HTTP
  * 'clientError' can now be used to return custom errors from an
    HTTP server [#4557](#4557).
* Modules
  * Current directory is now prioritized for local lookups
    [#5689](#5689)
  * Symbolic links are preserved when requiring modules
    [#5950](#5950)
* Net
  * DNS hints no longer implicitly set
    [#6021](#6021).
  * Improved error handling and type checking
    [#5981](#5981),
    [#5733](#5733),
    [#2904](#2904)
* OS X
  * MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7
    [#6402](#6402).
* Path
  * Improved type checking [#5348](#5348).
* Process
  * Introduce process warnings API
    [#4782](#4782).
  * Throw exception when non-function passed to nextTick
    [#3860](#3860).
* Readline
  * Emit key info unconditionally
    [#6024](#6024)
* REPL
  * Assignment to `_` will emit a warning.
    [#5535](#5535)
* Timers
  * Fail early when callback is not a function
    [#4362](#4362)
* TLS
  * Rename 'clientError' to 'tlsClientError'
    [#4557](#4557)
  * SHA1 used for sessionIdContext
    [#3866](#3866)
* TTY
  * Previously deprecated setRawMode wrapper is removed
    [#2528](#2528).
* Util
  * Changes to Error object formatting
    [#4582](#4582).
* Windows
  * Windows XP and Vista are no longer supported
    [#5167](#5167),
    [#5167](#5167).
jasnell added a commit that referenced this pull request Apr 26, 2016
@jasnell
2016-04-26, Version 6.0.0 (Current) Release
1a29a57 
The following significant (semver-major) changes have been made since the
previous Node v5.0.0 release.

* Buffer
  * New Buffer constructors have been added
    [#4682](#4682)
  * Previously deprecated Buffer APIs are removed
    [#5048](#5048),
    [#4594](#4594)
  * Improved error handling [#4514](#4514)
* Cluster
  * Worker emitted as first argument in 'message' event
    [#5361](#5361).
* Crypto
  * Improved error handling [#3100](#3100),
    [#5611](#5611)
  * Simplified Certificate class bindings
    [#5382](#5382)
  * Improved control over FIPS mode
    [#5181](#5181)
  * pbkdf2 digest overloading is deprecated
    [#4047](#4047)
* Dependencies
  * Reintroduce shared c-ares build support
    [#5775](#5775).
  * V8 updated to 5.0.71.31 [#6111](#6111).
* DNS
  * Add resolvePtr API to query plain DNS PTR records
    [#4921](#4921).
* Domains
  * Clear stack when no error handler
  [#4659](#4659).
* File System
  * The `fs.realpath()` and `fs.realpathSync()` methods have been updated
    to use a more efficient libuv implementation. This change includes the
    removal of the `cache` argument and the method can throw new errors
    [#3594](#3594)
  * FS apis can now accept and return paths as Buffers
    [#5616](#5616).
  * Error handling and type checking improvements
    [#5616](#5616),
    [#5590](#5590),
    [#4518](#4518),
    [#3917](#3917).
  * fs.read's string interface is deprecated
    [#4525](#4525)
* HTTP
  * 'clientError' can now be used to return custom errors from an
    HTTP server [#4557](#4557).
* Modules
  * Current directory is now prioritized for local lookups
    [#5689](#5689)
  * Symbolic links are preserved when requiring modules
    [#5950](#5950)
* Net
  * DNS hints no longer implicitly set
    [#6021](#6021).
  * Improved error handling and type checking
    [#5981](#5981),
    [#5733](#5733),
    [#2904](#2904)
* OS X
  * MACOSX_DEPLOYMENT_TARGET has been bumped up to 10.7
    [#6402](#6402).
* Path
  * Improved type checking [#5348](#5348).
* Process
  * Introduce process warnings API
    [#4782](#4782).
  * Throw exception when non-function passed to nextTick
    [#3860](#3860).
* Readline
  * Emit key info unconditionally
    [#6024](#6024)
* REPL
  * Assignment to `_` will emit a warning.
    [#5535](#5535)
* Timers
  * Fail early when callback is not a function
    [#4362](#4362)
* TLS
  * Rename 'clientError' to 'tlsClientError'
    [#4557](#4557)
  * SHA1 used for sessionIdContext
    [#3866](#3866)
* TTY
  * Previously deprecated setRawMode wrapper is removed
    [#2528](#2528).
* Util
  * Changes to Error object formatting
    [#4582](#4582).
* Windows
  * Windows XP and Vista are no longer supported
    [#5167](#5167),
    [#5167](#5167).
@Trott
Copy link
Member

Trott commented Apr 28, 2016

Looks like this was landed without a CI run. :-(

@ChALkeR
Copy link
Member Author

ChALkeR commented Apr 28, 2016

@Trott The CI run was made for the whole 6.0.0 release, and this was the last commit before the release.

@jasnell
Copy link
Member

jasnell commented Apr 28, 2016

@ChALkeR ... the CI run for v6 didn't include this because it came in just after I kicked that off. I ran the tests locally but I already had the work around in place that @bnoordhuis identified (which explains why I haven't been able to recreate this locally... I just switched that back off and low and behold, getting the error).

@richardlau richardlau mentioned this pull request Feb 9, 2017
Closed
@rvagg rvagg mentioned this pull request Apr 17, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. macos Issues and PRs related to the macOS platform / OSX. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.
10 participants
@ChALkeR @ofrobots @evanlucas @bnoordhuis @cjihrig @jasnell @indutny @MylesBorins @Trott @Fishrock123