Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: backport 8eda85d from v8 upstream #6424

Conversation

indutny
Copy link
Member

@indutny indutny commented Apr 27, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

Original commit message:

Postmortem: export DATA_CONSTANT

Useful for inspecting constant fields in objects.

BUG=
R=machenbach

Review-Url: https://codereview.chromium.org/1922903003
Cr-Commit-Position: refs/heads/master@{#35826}

Note: this is really useful for llnode, since EventHandlers
fields are stored as a constant fields in the v6.

cc @nodejs/v8

Original commit message:

    Postmortem: export DATA_CONSTANT

    Useful for inspecting constant fields in objects.

    BUG=
    R=machenbach

    Review-Url: https://codereview.chromium.org/1922903003
    Cr-Commit-Position: refs/heads/master@{nodejs#35826}

Note: this is really useful for llnode, since `EventHandlers`
fields are stored as a constant fields in the v6.
@indutny
Copy link
Member Author

indutny commented Apr 27, 2016

@mscdex mscdex added the v8 engine Issues and PRs related to the V8 dependency. label Apr 27, 2016
@bnoordhuis
Copy link
Member

LGTM, I guess, but can't this be cherry-picked to v5.0 upstream, followed by a wholesale upgrade here?

@indutny
Copy link
Member Author

indutny commented Apr 27, 2016

Yep, sounds like a good plan.

@indutny
Copy link
Member Author

indutny commented Apr 27, 2016

Wait, v8 v5 upstream? I'll ping them about it.

@bnoordhuis
Copy link
Member

The branch is still open, AFAIK, so you should be able to tools/release/merge_to_branch.py it.

@jeisinger
Copy link
Contributor

@natorion manages back-merges to active v8 branches, please sync with him

@natorion
Copy link

Could you please use the process outlined in https://github.com/v8/v8/wiki/Merging%20&%20Patching ? I think Fedor already created a bug?

@indutny
Copy link
Member Author

indutny commented Apr 28, 2016

@natorion yeah, will do it correctly this time. Sorry! 👍

@indutny
Copy link
Member Author

indutny commented May 4, 2016

Should come to use with the next v8 upgrade. cc @ofrobots

@ofrobots
Copy link
Contributor

ofrobots commented May 4, 2016

Next v8 upgrade contains this: #6572. Once that lands on master, it can be merged to v6.x as well (I can do that).

This issue could be closed; except that it has the lts-watch-4.x tag.

@indutny
Copy link
Member Author

indutny commented May 4, 2016

Thank you @ofrobots !

@indutny indutny deleted the feature/backport-v8-8eda85d54edfa9fec95b22c9afdac0560e72eae1 branch May 4, 2016 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants