-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: backport 8eda85d from v8 upstream #6424
deps: backport 8eda85d from v8 upstream #6424
Conversation
Original commit message: Postmortem: export DATA_CONSTANT Useful for inspecting constant fields in objects. BUG= R=machenbach Review-Url: https://codereview.chromium.org/1922903003 Cr-Commit-Position: refs/heads/master@{nodejs#35826} Note: this is really useful for llnode, since `EventHandlers` fields are stored as a constant fields in the v6.
LGTM, I guess, but can't this be cherry-picked to v5.0 upstream, followed by a wholesale upgrade here? |
Yep, sounds like a good plan. |
Wait, v8 v5 upstream? I'll ping them about it. |
The branch is still open, AFAIK, so you should be able to |
@natorion manages back-merges to active v8 branches, please sync with him |
Could you please use the process outlined in https://github.com/v8/v8/wiki/Merging%20&%20Patching ? I think Fedor already created a bug? |
@natorion yeah, will do it correctly this time. Sorry! 👍 |
Should come to use with the next v8 upgrade. cc @ofrobots |
Next v8 upgrade contains this: #6572. Once that lands on master, it can be merged to v6.x as well (I can do that). This issue could be closed; except that it has the |
Thank you @ofrobots ! |
Checklist
Affected core subsystem(s)
deps
Description of change
Original commit message:
Note: this is really useful for llnode, since
EventHandlers
fields are stored as a constant fields in the v6.
cc @nodejs/v8