Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix max size check in Buffer constructor #657

Merged
merged 1 commit into from
Jan 31, 2015
Merged

lib: fix max size check in Buffer constructor #657

merged 1 commit into from
Jan 31, 2015

Commits on Jan 31, 2015

  1. lib: fix max size check in Buffer constructor 

    A number -> uint32 type coercion bug made buffer sizes
larger than kMaxLength (0x3fffffff) wrap around.

Instead of rejecting the requested size with an exception,
the constructor created a buffer with the wrong size.

PR-URL: nodejs#657
Reviewed-By: Trevor Norris <[email protected]>
    @bnoordhuis
    bnoordhuis committed Jan 31, 2015
    Configuration menu
    Copy the full SHA
    0767c2f View commit details
    Browse the repository at this point in the history