-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CTC meeting minutes for 2016-05-04 #6579
Conversation
Cherry-pick c4040c6 (I just copy/pasted from the |
LGTM |
* Steven R Loomis @srl295 (observer/IBM/ICU) | ||
* Trevor Norris @trevnorris (CTC) | ||
* Rich Trott @Trott (CTC) | ||
* Bradley Farias @bmeck (observer/modules EPS/GoDaddy) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not in sorted order
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorted by handler with exception of Bradley Farias
@Trott what editor did you use. I tried doing the cherry pick but I get this error even adding the node.js as an upstream repo and fetching the upstream: mhdawson@duv-aurora:~/pulls/tsc-meet/io.js/doc/ctc-meetings$ git cherry-pick c4040c6 I also tried the copy from README.md but in vi I got something closer but not the full name |
@mhdawson I think that’s because the commit is not connected to any branch here, so git doesn’t fetch it. |
@addaleax A big thanks, that worked :) Updated to address comments so far. Will squash commits when its landed |
LGTM |
Have a few oks, will plan to land monday unless there are objections before then |
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
Landed as 7f1111b |
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
PR-URL: #6579 Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Evan Lucas <[email protected]> Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
Add CTC meeting minutes for 2016-05-04
Not sure how to get Chalker's name to show up correctly. If anybody knows how please let me know