Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CTC meeting minutes for 2016-05-04 #6579

Closed
wants to merge 3 commits into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented May 4, 2016

Add CTC meeting minutes for 2016-05-04

Not sure how to get Chalker's name to show up correctly. If anybody knows how please let me know

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 4, 2016
@Trott
Copy link
Member

Trott commented May 4, 2016

Not sure how to get Chalker's name to show up correctly. If anybody knows how please let me know

Cherry-pick c4040c6

(I just copy/pasted from the README.)

@MylesBorins
Copy link
Contributor

LGTM

* Steven R Loomis @srl295 (observer/IBM/ICU)
* Trevor Norris @trevnorris (CTC)
* Rich Trott @Trott (CTC)
* Bradley Farias @bmeck (observer/modules EPS/GoDaddy)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in sorted order

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorted by handler with exception of Bradley Farias

@mhdawson
Copy link
Member Author

mhdawson commented May 5, 2016

@Trott what editor did you use. I tried doing the cherry pick but I get this error even adding the node.js as an upstream repo and fetching the upstream:

mhdawson@duv-aurora:~/pulls/tsc-meet/io.js/doc/ctc-meetings$ git cherry-pick c4040c6
fatal: bad object c4040c6

I also tried the copy from README.md but in vi I got something closer but not the full name

@addaleax
Copy link
Member

addaleax commented May 5, 2016

@mhdawson I think that’s because the commit is not connected to any branch here, so git doesn’t fetch it. curl https://github.com/nodejs/node/commit/c4040c66f3b037ee901464a18c4bc7e9b6d6daf0.patch | git am should work better. :)

@mhdawson
Copy link
Member Author

mhdawson commented May 5, 2016

@addaleax A big thanks, that worked :)

Updated to address comments so far. Will squash commits when its landed

@jasnell
Copy link
Member

jasnell commented May 6, 2016

LGTM

@mhdawson
Copy link
Member Author

mhdawson commented May 6, 2016

Have a few oks, will plan to land monday unless there are objections before then

mhdawson added a commit that referenced this pull request May 9, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented May 9, 2016

Landed as 7f1111b

@mhdawson mhdawson closed this May 9, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #6579
Reviewed-By: Myles Borins <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Evan Lucas <[email protected]>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <[email protected]>
@mhdawson mhdawson deleted the ctc-meet branch March 15, 2017 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants