Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add added: information for url, querystring #6593

Closed
wants to merge 2 commits into from
Closed

doc: add added: information for url, querystring #6593

wants to merge 2 commits into from

Conversation

bengl
Copy link
Member

@bengl bengl commented May 5, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added introduction version metadata in url.md and querystring.md.

Ref: #6578

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 5, 2016
@sam-github sam-github mentioned this pull request May 5, 2016
Closed
36 tasks
@addaleax addaleax added querystring Issues and PRs related to the built-in querystring module. url Issues and PRs related to the legacy built-in url module. labels May 5, 2016
@jasnell
Copy link
Member

jasnell commented May 5, 2016

pinging @nodejs/documentation for review.

@bnoordhuis
Copy link
Member

LGTM

3 similar comments
@jasnell
Copy link
Member

jasnell commented May 6, 2016

LGTM

@Qard
Copy link
Member

Qard commented May 6, 2016

LGTM

@addaleax
Copy link
Member

addaleax commented May 9, 2016

LGTM

addaleax pushed a commit that referenced this pull request May 9, 2016
@bengl @addaleax
doc: add added: information for querystring
f773073 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit that referenced this pull request May 9, 2016
@bengl @addaleax
doc: add added: information for url
43e4baf 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax
Copy link
Member

addaleax commented May 9, 2016

Landed in f773073 and 43e4baf.

@addaleax addaleax closed this May 9, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bengl @evanlucas
doc: add added: information for querystring
715b48c 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bengl @evanlucas
doc: add added: information for url
d5f7f24 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@bengl @addaleax
doc: add added: information for querystring
65c09f6 
Module introduced in 7ff04c1.

Ref: nodejs#6578
PR-URL: nodejs#6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@bengl @addaleax
doc: add added: information for url
1e72bf1 
Module introduced in 7ff04c1.

Ref: nodejs#6578
PR-URL: nodejs#6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bengl
doc: add added: information for querystring
e9da7de 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bengl
doc: add added: information for url
40e4dac 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bengl
doc: add added: information for querystring
1529be9 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bengl
doc: add added: information for url
fa2e987 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bengl
doc: add added: information for querystring
9899298 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bengl
doc: add added: information for url
7600a54 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bengl
doc: add added: information for querystring
eec0c63 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bengl
doc: add added: information for url
1758f02 
Module introduced in 7ff04c1.

Ref: #6578
PR-URL: #6593
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Stephen Belanger <[email protected]>
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. querystring Issues and PRs related to the built-in querystring module. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bengl @jasnell @bnoordhuis @Qard @addaleax @MylesBorins @nodejs-github-bot