test: allow out-of-order replies in dgram tests #6607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
dgram
| client.close(); | ||
| } | ||
| }); | ||
| }, toSend.length)); |
There was a problem hiding this comment.
Why are you passing toSend.length here?
There was a problem hiding this comment.
Making sure that the message event is invoked for each message – otherwise the test would accept messages just being dropped.
There was a problem hiding this comment.
Apologies, I missed it was an argument to mustCall.
|
LGTM |
|
LGTM |
1 similar comment
|
LGTM |
2 tasks
|
LGTM |
|
BTW, can you please sweep through all dgram tests? I think I copied the structure of those from another one, which probably has the same issue. |
|
@mcollina I went through them and there seemed to be no other tests with this problem, just these two. |
|
@addaleax thx for checking and fixing! |
addaleax
force-pushed
the
fix-udp-default-host-tests
branch
from
76d7b00
to
2e66c82
Compare
Allow out of order replies in the flaky
`test-dgram{-upd6,}-send-default-host.js` files by sorting
the incoming replies after receiving them.
Fixes: nodejs#6577
PR-URL: nodejs#6607
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
addaleax
force-pushed
the
fix-udp-default-host-tests
branch
from
2e66c82
to
c5a8bd5
Compare
addaleax
added a commit
to addaleax/node
that referenced
this pull request
May 10, 2016
Allow out of order replies in the flaky
`test-dgram{-upd6,}-send-default-host.js` files by sorting
the incoming replies after receiving them.
PR-URL: nodejs#6607
Fixes: nodejs#6577
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Allow out of order replies in the flaky
`test-dgram{-upd6,}-send-default-host.js` files by sorting
the incoming replies after receiving them.
PR-URL: #6607
Fixes: #6577
Reviewed-By: Ben Noordhuis <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: James M Snell <[email protected]>
Reviewed-By: Santiago Gimeno <[email protected]>
Reviewed-By: Matteo Collina <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test, dgram
Description of change
Allow out of order replies in the flaky
test-dgram{-upd6,}-send-default-host.jsfiles by sorting the incoming replies after receiving them.Fixes: #6577
/cc @Trott @santigimeno