Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't compile with -B, redux #6650

Merged
merged 1 commit into from
May 10, 2016
Merged

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented May 9, 2016

It looks like suppressing -B and -fuse-ld=gold from common.gypi is
not very reliable. I'm positive it worked when commit 3cdb506 ("build:
don't compile with -B") was merged but subsequent updates appear to have
broken it again.

Take the nuclear option and disable them from tools/node_gyp.py.

Fixes: #6603
Refs: #6393

CI: https://ci.nodejs.org/job/node-test-pull-request/2545/

@bnoordhuis bnoordhuis added the build Issues and PRs related to build files or the CI. label May 9, 2016
@mhart
Copy link
Contributor

mhart commented May 9, 2016

Great, this works for me (without needing binutils-gold installed). Is there any way these flags can be set via an env variable?

@bnoordhuis
Copy link
Member Author

Yes. export GYP_DEFINES="linux_use_bundled_binutils=0 linux_use_bundled_gold=0 linux_use_gold_flags=0" should do it.

@mhart
Copy link
Contributor

mhart commented May 9, 2016

I swear I tried that already 😸 – maybe I only had linux_use_gold_flags=0 and not the others though

@mhart
Copy link
Contributor

mhart commented May 9, 2016

Great, confirmed, setting GYP_DEFINES works too

@mhart
Copy link
Contributor

mhart commented May 9, 2016

(turns out the problem previously was that I was setting GYP_DEFINES but not exporting it... duh. So can also just do export GYP_DEFINES="linux_use_gold_flags=0" – that alone works in my case)

@bnoordhuis
Copy link
Member Author

Maybe R=@addaleax?

@addaleax
Copy link
Member

Yeah, LGTM and 👍 for the helpful pointer to deps/v8/build/toolchain.gypi.

It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is
not very reliable.  I'm positive it worked when commit 3cdb506 ("build:
don't compile with -B") was merged but subsequent updates appear to have
broken it again.

Take the nuclear option and disable them from `tools/node_gyp.py`.

Fixes: nodejs#6603
PR-URL: nodejs#6650
Refs: nodejs#6393
Reviewed-By: Anna Henningsen <[email protected]>
@bnoordhuis bnoordhuis closed this May 10, 2016
@bnoordhuis bnoordhuis deleted the fix6603 branch May 10, 2016 11:00
@bnoordhuis bnoordhuis merged commit 584f93a into nodejs:master May 10, 2016
evanlucas pushed a commit that referenced this pull request May 17, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is
not very reliable.  I'm positive it worked when commit 3cdb506 ("build:
don't compile with -B") was merged but subsequent updates appear to have
broken it again.

Take the nuclear option and disable them from `tools/node_gyp.py`.

Fixes: #6603
PR-URL: #6650
Refs: #6393
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 2, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is
not very reliable.  I'm positive it worked when commit 3cdb506 ("build:
don't compile with -B") was merged but subsequent updates appear to have
broken it again.

Take the nuclear option and disable them from `tools/node_gyp.py`.

Fixes: #6603
PR-URL: #6650
Refs: #6393
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is
not very reliable.  I'm positive it worked when commit 3cdb506 ("build:
don't compile with -B") was merged but subsequent updates appear to have
broken it again.

Take the nuclear option and disable them from `tools/node_gyp.py`.

Fixes: #6603
PR-URL: #6650
Refs: #6393
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
It looks like suppressing `-B` and `-fuse-ld=gold` from common.gypi is
not very reliable.  I'm positive it worked when commit 3cdb506 ("build:
don't compile with -B") was merged but subsequent updates appear to have
broken it again.

Take the nuclear option and disable them from `tools/node_gyp.py`.

Fixes: #6603
PR-URL: #6650
Refs: #6393
Reviewed-By: Anna Henningsen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants