Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix tools/doc/addon-verify.js regression (and more) #6652

Merged
merged 4 commits into from
May 10, 2016
Merged

tools: fix tools/doc/addon-verify.js regression (and more) #6652

merged 4 commits into from
May 10, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented May 9, 2016 •
edited
Loading

@bnoordhuis bnoordhuis added doc Issues and PRs related to the documentations. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests. lts-watch-v4.x labels May 9, 2016
@bnoordhuis bnoordhuis mentioned this pull request May 9, 2016
Closed
2 tasks
@addaleax
Copy link
Member

addaleax commented May 9, 2016

Tiniest of nits: In the last commit’s message, the quotes are mismatched. 😉

LGTM!

@bnoordhuis
Copy link
Member Author

Looks like the Windows buildbots are having network connectivity issues...

@bnoordhuis
Copy link
Member Author

New CI: https://ci.nodejs.org/job/node-test-pull-request/2556/

bnoordhuis and others added 4 commits May 10, 2016 17:10
@bnoordhuis
test: build addons with V8_DEPRECATION_WARNINGS=1
f644368 
PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <[email protected]>
@bnoordhuis
doc: fix deprecation warnings in addon examples
2c75a6b 
Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <[email protected]>
@bnoordhuis
build,test: fix build-addons dependency chain
0ea4855 
* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <[email protected]>
@addaleax @bnoordhuis
tools: fix tools/doc/addon-verify.js regression
4f925dd 
Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: nodejs#6652
Reviewed-By: Ben Noordhuis <[email protected]>
@bnoordhuis bnoordhuis closed this May 10, 2016
@bnoordhuis bnoordhuis deleted the fix-doc-addons branch May 10, 2016 17:02
@bnoordhuis bnoordhuis merged commit 4f925dd into nodejs:master May 10, 2016
@bnoordhuis
Copy link
Member Author

Landed with commit log amended. :-)

Release people: commit 4f925dd depends on #6396, the other commits should cherry-pick cleanly.

evanlucas pushed a commit that referenced this pull request May 17, 2016
@addaleax @evanlucas
tools: fix tools/doc/addon-verify.js regression
26805c9 
Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <[email protected]>
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bnoordhuis @evanlucas
build,test: fix build-addons dependency chain
6eed6a3 
* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
@evanlucas evanlucas mentioned this pull request May 17, 2016
Merged
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bnoordhuis @evanlucas
test: build addons with V8_DEPRECATION_WARNINGS=1
f264749 
PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
evanlucas pushed a commit that referenced this pull request May 17, 2016
@bnoordhuis @evanlucas
doc: fix deprecation warnings in addon examples
8f52649 
Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
@MylesBorins
Copy link
Contributor

I've marked this and #6396 as do not land for lts

No need for the fix if the regression isn't introduced. More than happy to review a backport of a working changeset

addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@bnoordhuis @addaleax
test: build addons with V8_DEPRECATION_WARNINGS=1
5b34603 
PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@bnoordhuis @addaleax
doc: fix deprecation warnings in addon examples
9929173 
Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <[email protected]>
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@bnoordhuis @addaleax
build,test: fix build-addons dependency chain
6faecba 
* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: nodejs#6652
Reviewed-By: Anna Henningsen <[email protected]>
addaleax added a commit to addaleax/node that referenced this pull request Jul 12, 2016
@addaleax
tools: fix tools/doc/addon-verify.js regression
4e8e59b 
Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: nodejs#6652
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bnoordhuis
test: build addons with V8_DEPRECATION_WARNINGS=1
5d7f7e7 
PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bnoordhuis
doc: fix deprecation warnings in addon examples
ee5e3d0 
Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bnoordhuis
build,test: fix build-addons dependency chain
1dee4b3 
* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@addaleax
tools: fix tools/doc/addon-verify.js regression
eb53ff3 
Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bnoordhuis
test: build addons with V8_DEPRECATION_WARNINGS=1
fd5ec9b 
PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bnoordhuis
doc: fix deprecation warnings in addon examples
4d3b450 
Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@bnoordhuis
build,test: fix build-addons dependency chain
4c85272 
* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@addaleax
tools: fix tools/doc/addon-verify.js regression
a79aed1 
Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <[email protected]>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
test: build addons with V8_DEPRECATION_WARNINGS=1
5069387 
PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
doc: fix deprecation warnings in addon examples
6237508 
Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
build,test: fix build-addons dependency chain
d34fa13 
* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@addaleax
tools: fix tools/doc/addon-verify.js regression
7304b0f 
Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
test: build addons with V8_DEPRECATION_WARNINGS=1
686d7b3 
PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
doc: fix deprecation warnings in addon examples
b869cdb 
Use the overload of `v8::Function::NewInstance()` that returns a
`v8::MaybeLocal<v8::Object>`.  The overloads that return a simple
`v8::Local<v8::Object>` are deprecated.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@bnoordhuis
build,test: fix build-addons dependency chain
ea20796 
* Make the 'extract embedded addons in the documentations' step a normal
  prerequisite.  As an order-only prerequisite, it's sometimes skipped
  when it shouldn't be.

* Make `tools/doc/addon-verify.js` a dependency of that step.  Changes
  to that file should result in a rebuild.

PR-URL: #6652
Reviewed-By: Anna Henningsen <[email protected]>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@addaleax
tools: fix tools/doc/addon-verify.js regression
ed193ad 
Introduced in commit 3f69ea5 ("tools: update marked dependency"), it
stopped the embedded addons in the documentation from getting built.

PR-URL: #6652
Reviewed-By: Ben Noordhuis <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bnoordhuis @addaleax @MylesBorins