tools: use py2.6 equivalent of check_output #6714
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 2.6 does not have `subprocess.check_output`, as it was introduced only in Python 2.7. This patch uses `subprocess.Popen` to get the data written to stdout by the `pkg-config` program. Fixes: nodejs#6711
| stdout = subprocess.Popen(shlex.split(pkg_config) + [args, flag, pkg], | ||
| stdout=subprocess.PIPE).communicate()[0].strip() | ||
| except OSError as e: | ||
| if e.errno == errno.ENONET: |
|
Isn't this basically the patch I posted in #6711 (comment)? |
|
@bnoordhuis Yes it is. Were you waiting for the OP to confirm before sending the patch? Sorry I jumped the line :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools
Description of change
Python 2.6 does not have
subprocess.check_output, as it wasintroduced only in Python 2.7. This patch uses
subprocess.Popentoget the data written to stdout by the
pkg-configprogram.Fixes: #6711
cc @bnoordhuis