Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: measure buffer length in bytes #6764

Closed
wants to merge 12 commits into from
Closed

child_process: measure buffer length in bytes #6764

wants to merge 12 commits into from

Commits on May 22, 2016

  1. child_process: measure buffer length in bytes 

    This change fixes a known issue where `maxBuffer` limits by characters
rather than bytes. Benchmark added to confirm no performance regression
occurs with this change.

Fixes: nodejs#1901
    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    e20ff77 View commit details
    Browse the repository at this point in the history

  2. squash: run toString() just once at the end

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    3245de6 View commit details
    Browse the repository at this point in the history

  3. squash: optimize Buffer.concat(), handle edge case

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    7b96b64 View commit details
    Browse the repository at this point in the history

  4. squash: benchmark nits

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    2b14b64 View commit details
    Browse the repository at this point in the history

  5. squash: comment block explaining chunk.length

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    221dec5 View commit details
    Browse the repository at this point in the history

  6. squash: get correct length for strings

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    425128f View commit details
    Browse the repository at this point in the history

  7. squash

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    2d56158 View commit details
    Browse the repository at this point in the history

  8. squash

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    bce02ef View commit details
    Browse the repository at this point in the history

  9. squash: nothing but nits

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    a8ba111 View commit details
    Browse the repository at this point in the history

  10. squash

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    32925da View commit details
    Browse the repository at this point in the history

  11. squash: comment nit fixes

    @Trott
    Trott committed May 22, 2016
    Configuration menu
    Copy the full SHA
    ec2cf57 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2016

  1. squash: fix comment

    @Trott
    Trott committed May 24, 2016
    Configuration menu
    Copy the full SHA
    561c798 View commit details
    Browse the repository at this point in the history