Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: robust handling of env for npm-test-install #6797

Merged
merged 1 commit into from
May 18, 2016
Merged

test: robust handling of env for npm-test-install #6797

merged 1 commit into from
May 18, 2016

Commits on May 18, 2016

  1. test: robust handling of env for npm-test-install 

    Currently we are overwriting the entire env object of the child-process
spawned in `npm-test-install`. This commit alternatively clones the
`process.env` object and modifies it with the neccessary changes before
passing it the the spawned process.

Fixes: nodejs#6736

PR-URL: nodejs#6797
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: James M Snell <[email protected]>
    @MylesBorins
    Myles Borins authored and MylesBorins committed May 18, 2016
    Configuration menu
    Copy the full SHA
    56ae651 View commit details
    Browse the repository at this point in the history