doc: add note for fs.watch on virtualized env #6809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eljefedelrodeodeljefe
added
doc
|
LGTM |
1 similar comment
|
LGTM |
| reliably or at all. | ||
| directories on network file systems (NFS, SMB, etc.) and on exposed host file | ||
| systems when using virtualization software (Vagrant, Docker, etc.) often doesn't | ||
| work reliably or at all. | ||
|
|
There was a problem hiding this comment.
minor nit... I'd restructure the sentence just a bit...
Something like:
For example, watching files or directories can be unreliable, and in some
cases impossible, on network file systems (NFS, SMB, etc), and on host
file systems when using virtualization software such as Vagrant, Docker, etc.
But I'm good with this also ;-)
|
Left one comment but generally LGTM |
|
Fine for me. Will adapt it before landing. Thx |
|
I'm + 1for @jasnell's version, but generally LGTM as well. |
| @@ -1180,8 +1180,9 @@ to be notified of filesystem changes. | |||
|
|
|||
| If the underlying functionality is not available for some reason, then | |||
| `fs.watch` will not be able to function. For example, watching files or | |||
| directories on network file systems (NFS, SMB, etc.) often doesn't work | |||
| reliably or at all. | |||
| directories on network file systems (NFS, SMB, etc.) and on exposed host file | |||
There was a problem hiding this comment.
s/and on/or/? I suspect most programmers are like me and interpret it boolean logic-style.
|
LGTM with a suggestion. |
Fixes: #6765 PR-URL: #6809 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
eljefedelrodeodeljefe
added a commit
that referenced
this pull request
May 19, 2016
Fixes: #6765 PR-URL: #6809 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
|
Went ahead and landed it in ae0f68d Addressed both @bnoordhuis an @jasnell nits |
Fishrock123
pushed a commit
that referenced
this pull request
May 23, 2016
Fixes: #6765 PR-URL: #6809 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
Fixes: #6765 PR-URL: #6809 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 3, 2016
Fixes: #6765 PR-URL: #6809 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Fixes: #6765 PR-URL: #6809 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
Fixes: #6765 PR-URL: #6809 Reviewed-By: Ben Noordhuis <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]> Reviewed-By: Michael Dawson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
docDescription of change
On virtualization systems
fs.watchdoesn't work reliably, which is implicitly already in the respective docs. To make it more explicit this PR adds a subsentence. The following statement defers to use of fs.watchFile, which is the potential workaround.Fixes: #6765