doc: add info on what's used for fswatch on AIX #6837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Info is provided on for the other OS's. Add similar level of info for AIX.
|
LGTM |
1 similar comment
|
LGTM |
| @@ -1467,6 +1467,7 @@ to be notified of filesystem changes. | |||
| * On OS X, this uses `kqueue` for files and 'FSEvents' for directories. | |||
| * On SunOS systems (including Solaris and SmartOS), this uses `event ports`. | |||
| * On Windows systems, this feature depends on `ReadDirectoryChangesW`. | |||
| * On Aix systems, this feature depends on `AHAFS`, which must be enabled. | |||
There was a problem hiding this comment.
Hmm.. it would be excellent if these were links (e.g. if kqueue' was a link to more information onkqueue,event portswas a link to more information on that,AHAFS` was a link to more information on that, etc). That could be done in a separate PR tho.
|
Small nit but LGTM |
|
@jasnell, good idea, I'll land this and put it on my queue to submit a new one with the links added for all. |
mhdawson
added a commit
that referenced
this pull request
May 27, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
|
Landed as 8af25a3 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: nodejs#6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
rvagg
pushed a commit
that referenced
this pull request
Jun 2, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 11, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 12, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2016
Info is provided on for the other OS's. Add similar level of info for AIX. PR-URL: #6837 Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Santiago Gimeno <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
fs
Description of change
Noticed we don't mention how fswatch is implemented for AIX like
we do on other platforms, adding