Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: check accessing a null stderr #6877

Closed
wants to merge 2 commits into from
Closed

child_process: check accessing a null stderr #6877

wants to merge 2 commits into from

Commits on Jul 11, 2016

  1. child_process: Check stderr before accessing it 

    If something bad happens in spawnSync, stderr might be null. Therefore,
we have to check it before using it, so we won't mask the actual
exception.

Signed-off-by: Robert Chiras <[email protected]>
    @robertchiras
    robertchiras committed Jul 11, 2016
    Configuration menu
    Copy the full SHA
    646a211 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2016

  1. test: Additional test for execSync 

    Exercise the call to execSync with a bad shell passed through options.
Verify that the right exception is thrown.

Signed-off-by: Robert Chiras <[email protected]>
    @robertchiras
    robertchiras committed Jul 19, 2016
    Configuration menu
    Copy the full SHA
    91ff704 View commit details
    Browse the repository at this point in the history