Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: work around debugger not killing inferior #7037

Merged
merged 1 commit into from
May 28, 2016
Merged

test: work around debugger not killing inferior #7037

merged 1 commit into from
May 28, 2016

Commits on May 28, 2016

  1. test: work around debugger not killing inferior 

    On UNIX platforms, the debugger doesn't reliably kill the inferior when
killed by a signal.  Work around that by spawning the debugger in its
own process group and killing the process group instead of just the
debugger process.

This is a hack to get the continuous integration back to green, it
doesn't address the underlying issue, which is that the debugger
shouldn't leave stray processes behind.

Fixes: nodejs#7034
Refs: nodejs#3470
Reviewed-By: Colin Ihrig <[email protected]>
    @bnoordhuis
    bnoordhuis committed May 28, 2016
    Configuration menu
    Copy the full SHA
    3bc47d2 View commit details
    Browse the repository at this point in the history