src: add linebreak to --inspect message #7070
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
| @@ -31,7 +31,7 @@ namespace { | |||
| const char DEVTOOLS_PATH[] = "/node"; | |||
|
|
|||
| void PrintDebuggerReadyMessage(int port) { | |||
| fprintf(stderr, "Debugger listening on port %d. " | |||
| fprintf(stderr, "Debugger listening on port %d. \n" | |||
There was a problem hiding this comment.
If there’s a line break here anyway, the preceding space might as well be removed, no?
|
LGTM, thanks! For reference, this fixes bug #7067; you can include a |
to prevent ugly line break in 80 column(default) terminal windows Fixes: nodejs#7067
|
Aha, I was wondering how to link the issue to the pull request – I'll add that to the log. Might be useful to mention in the contributing doc. |
nicolasromer
force-pushed
the
inspector-fix-linebreak
branch
from
da38af3
to
79e073e
Compare
|
LGTM, second commit will need to be fixed-up but I can do that while landing (also probably change the word "ugly" just to be extra safe with the CoC). |
|
CI failure unrelated as far as I can see |
|
LGTM |
claudiorodriguez
pushed a commit
that referenced
this pull request
Jun 2, 2016
Add linebreak to inspector ready message to wrap properly in 80 column (default) terminal windows. Fixes: #7067 PR-URL: #7070 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
|
Landed in 3549a5e |
MylesBorins
added
inspector
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
Add linebreak to inspector ready message to wrap properly in 80 column (default) terminal windows. Fixes: #7067 PR-URL: #7070 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Claudio Rodriguez <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
src
Description of change
Added a newline in --inspect message after "Debugger listening on port %d." to prevent an ugly line break in 80 column(default) terminal windows