Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: fix --without-inspector build #7078

Merged
merged 1 commit into from
Jun 1, 2016

Conversation

addaleax
Copy link
Member

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

src

Description of change

Use HAVE_INSPECTOR as the 0/1 boolean macro that it is, as opposed to a defined/not-defined boolean.

@addaleax addaleax added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels May 31, 2016
@addaleax
Copy link
Member Author

@cjihrig
Copy link
Contributor

cjihrig commented May 31, 2016

LGTM

@mhdawson
Copy link
Member

LGTM, allowed me to compile AIX with --without-inspector

Use `HAVE_INSPECTOR` as the 0/1 boolean macro that it is, as opposed
to a defined/not-defined boolean.

PR-URL: nodejs#7078
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@addaleax addaleax force-pushed the fix-without-inspector-build branch from 6cfc1a7 to 3e7c5bc Compare June 1, 2016 18:27
@addaleax addaleax merged commit 3e7c5bc into nodejs:master Jun 1, 2016
@addaleax addaleax deleted the fix-without-inspector-build branch June 1, 2016 18:33
@addaleax addaleax added the inspector Issues and PRs related to the V8 inspector protocol label Jun 10, 2016
@MylesBorins MylesBorins added this to the 7.0.0 milestone Jun 14, 2016
Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
Use `HAVE_INSPECTOR` as the 0/1 boolean macro that it is, as opposed
to a defined/not-defined boolean.

PR-URL: #7078
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Michael Dawson <[email protected]>
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. inspector Issues and PRs related to the V8 inspector protocol lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants