Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test failure due to expired certificates #7195

Merged
merged 1 commit into from
Jun 7, 2016

Conversation

bnoordhuis
Copy link
Member

@bnoordhuis bnoordhuis commented Jun 7, 2016

Back-port commit 76f40f7 ("test: stronger crypto in test fixtures") from
the master branch.

Pushes back the expiration date of test/fixtures/keys/ca2-crl.pem to
2018, fixing a CRL_HAS_EXPIRED error in simple/test-tls-server-verify.

Fixes: #7194
CI: https://ci.nodejs.org/job/node-test-pull-request/2948/

Back-port commit 76f40f7 ("test: stronger crypto in test fixtures") from
the master branch.

Pushes back the expiration date of test/fixtures/keys/ca2-crl.pem to
2018, fixing a CRL_HAS_EXPIRED error in simple/test-tls-server-verify.

Fixes: nodejs#7194
PR-URL: nodejs#7195
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
@bnoordhuis bnoordhuis added test Issues and PRs related to the tests. lts-watch-v0.12 labels Jun 7, 2016
@mhdawson
Copy link
Member

mhdawson commented Jun 7, 2016

LGTM

1 similar comment
@MylesBorins
Copy link
Contributor

LGTM

@bnoordhuis bnoordhuis merged commit a14d5ae into nodejs:v0.12-staging Jun 7, 2016
@bnoordhuis bnoordhuis deleted the fix7194 branch June 7, 2016 17:04
mmallick-ca pushed a commit to ibmruntimes/node that referenced this pull request Oct 19, 2016
Back-port commit 76f40f7 ("test: stronger crypto in test fixtures") from
the master branch.

Pushes back the expiration date of test/fixtures/keys/ca2-crl.pem to
2018, fixing a CRL_HAS_EXPIRED error in simple/test-tls-server-verify.

Fixes: nodejs/node#7194
PR-URL: nodejs/node#7195
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
jBarz pushed a commit to ibmruntimes/node that referenced this pull request Nov 4, 2016
Back-port commit 76f40f7 ("test: stronger crypto in test fixtures") from
the master branch.

Pushes back the expiration date of test/fixtures/keys/ca2-crl.pem to
2018, fixing a CRL_HAS_EXPIRED error in simple/test-tls-server-verify.

Fixes: nodejs/node#7194
PR-URL: nodejs/node#7195
Reviewed-By: Michael Dawson <[email protected]>
Reviewed-By: Myles Borins <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants