inspector: process.exit should wait for inspector #7252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
|
lgtm |
|
LGTM |
|
For bonus points: factor out that magic number 32 into a constant and update PlatformInit() and WaitForInspectorDisconnect(). |
|
@bnoordhuis I introduced a constant and rebased the CL |
| @@ -187,6 +187,7 @@ static v8::Platform* default_platform; | |||
|
|
|||
| #ifdef __POSIX__ | |||
| static uv_sem_t debug_semaphore; | |||
| static const short NUM_SIGNALS = 32; | |||
There was a problem hiding this comment.
Can you name it e.g. kNumSignals or kMaxSignal? ALL_CAPS should be reserved for macros. LGTM apart from that.
|
@bnoordhuis I renamed to |
|
LGTM. ppcbe-ubuntu1404 seems to be stuck but everything else is green. |
|
Thanks, landed as 6626919. |
ofrobots
pushed a commit
that referenced
this pull request
Jun 13, 2016
Fixes: #7088 PR-URL: #7252 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]>
|
I am excluding this one from the next v6.x release since it is just a semver patch release. Once the inspector lands in v6.x, we can remove the dont-land-on-v6.x label. Thanks! |
Fishrock123
pushed a commit
that referenced
this pull request
Jul 5, 2016
Fixes: #7088 PR-URL: #7252 Reviewed-By: bnoordhuis - Ben Noordhuis <[email protected]> Conflicts: src/node.cc
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX) orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector
Description of change
Waits for the inspector frontend to detach when process.exit is called. This enables the user to analyse the profiling information.
Fixes: #7088